From 0f76115885032ae6aee6a491b82126f86559351d Mon Sep 17 00:00:00 2001 From: oumaimafisaoui Date: Mon, 8 Jul 2024 13:59:43 +0100 Subject: [PATCH] Fix: deleted undesired files, modified instructions, modified tests --- dom/skeleton_test.js | 15 ++++++++++++++- subjects/DPxAI/.DS_Store | Bin 6148 -> 0 bytes subjects/DPxAI/skeleton/.DS_Store | Bin 6148 -> 0 bytes subjects/DPxAI/skeleton/README.md | 12 +++++------- 4 files changed, 19 insertions(+), 8 deletions(-) delete mode 100644 subjects/DPxAI/.DS_Store delete mode 100644 subjects/DPxAI/skeleton/.DS_Store diff --git a/dom/skeleton_test.js b/dom/skeleton_test.js index 832ee0393..fd3ea7df1 100644 --- a/dom/skeleton_test.js +++ b/dom/skeleton_test.js @@ -6,6 +6,19 @@ tests.push(async ({ page, eq }) => { if (!title.length) throw Error('missing title') }) +tests.push(async ({ page, eq }) => { + // check that the title tag is set with text from the given list + const title = await page.$eval('title', (node) => node.textContent) + if (title !== 'invisibility' && title !== 'light-speed' && title !== 'super-strength' && title !== 'advanced-healing' && title !== 'mind-link') { + throw Error('wrong title, pick one of the list') + } + // invisibility + // light-speed + // super-strength + // advanced-healing + // mind-link +}) + tests.push(async ({ page, eq }) => { // check the face @@ -19,7 +32,7 @@ tests.push(async ({ page, eq }) => { }) tests.push(async ({ page, eq }) => { - // check the lower-body, my favorite part + // check the lower-body return eq.$('section:nth-child(3)', { textContent: 'lower-body' }) }) diff --git a/subjects/DPxAI/.DS_Store b/subjects/DPxAI/.DS_Store deleted file mode 100644 index 16a279605e570ed90d25d9b72e6ef723cd5c5b40..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeHK%}T>S5T32oZYe?!3VK`cTD96DikDdR;MIs8RBB^`24hy5)E-J9cYPsW#MjZ8 z-EBdtM@3}@X1~e&B-wAnZUz8EtKZ!Kr~-gQB`lP2_(Uj9Iwb|?nL!lh9wB6)Avucm z^;9-Hej@|4b`ny!gAiiW$@&Gc4lqU^#vbb0n-R1=$qxqUgUf#j9^xp?>h)Jqm?_TA zm1Id)a*9cY@O>9JH$o`#Q-wQ4;n{LDUT~<>D+#x_Z#k z{iK_kTHgj_S(e+?<>7F%*=W|(>ULvPQ^TFjdQCMOTcc4~F0QQa9=Gq}`$RvPR|kO~ zs*!nzV|Yemiik(Qm&7``!PvNNoX^M%FaylMA7;R9X|nQ%=fJPd3@`)V!vO6M3YE}v zm|HYk2M(qMKrEu$2-@_^NHxl#=P5ON z>rjMwI^JKIbP%3J9+?4V;3EUn`=M0n{6GA<|2IiIFaylM|71WE5B!4`&dr^zQ?sPA uR-s;@l2Bf5aZ-YYIf^ltj^ZU$Bj{ITAbJjSi|9e&9|1!H56r-iGVl)B7Fs+2 diff --git a/subjects/DPxAI/skeleton/.DS_Store b/subjects/DPxAI/skeleton/.DS_Store deleted file mode 100644 index 46cc050947f8c4422ae2d16386667947ed2de4a4..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeHKF-`+P474FdP@0sK`+`XPV2LgT1r2-vg_J?5=&#Cm_yRu*Gq#0@4jLpHG?why z^?Gh|Q=DTn^Y!cQ#%yV3b2!nC3{&GdePS1taUdMexVMe1?8SC>`$_fp339LO0lZrq zzVZ*x+x=mSQ~tC!`05mfl}rjq0VyB_q<|Foy#nmLu=yfUQ3^-_De$QPzYh&g?1f`u zd^!+f1OU#E4#PTT31DLa*bB!*WMH0DU{bwC3{N`pt?GK=n3#0)xEar>o4qC!kK2)N zQEuK76{Ua_I9K2@w@dc_4g81s|D2?q6p#Y{N&%k@kHZ?TRK0cba_qGY{sd>uJDi4f oP!OUW1EU>d!*+ZfMOoLl#(6Is6N8R?(1H3hKwV@~;I9?<0HMGdmjD0& diff --git a/subjects/DPxAI/skeleton/README.md b/subjects/DPxAI/skeleton/README.md index 4bc721175..a32067a47 100644 --- a/subjects/DPxAI/skeleton/README.md +++ b/subjects/DPxAI/skeleton/README.md @@ -8,14 +8,13 @@ To craft your robot friend, you first need to build its skeleton, and that's whe > For the whole quest, the principle is to iterate over your code: when you finish an exercise, copy-paste your code to use it in the next one. -> Contrary to what you will see in the videos, you don't have to run a server on your machine to use the html css javascript thanks to the integrated code editor that takes care of all that. +> Contrary to what you will see in the videos, you don't have to run a server on your machine to use the HTML, CSS and JavaScript thanks to the integrated code editor that takes care of all that. > We've left the videos for the other educational content they provide. ### Files naming - for the HTML files: `name-of-the-exercise.html` - for the CSS files: when you have to link one, it's named like so: `name-of-the-exercise.css` -- for the JS files, when you have to link one, it's named like so: `name-of-the-exercise.js` ### Resources @@ -25,7 +24,7 @@ We provide you with some content to get started smoothly, check it out! - Video [Basic set up of an HTML page](https://www.youtube.com/watch?v=QtKoO7tT-Gg&list=PLHyAJ_GrRtf979iZZ1N3qYMfsPj9PCCrF&index=1) - Video [Different HTML tags overview](https://www.youtube.com/watch?v=Al-Jzpib8VY&list=PLHyAJ_GrRtf979iZZ1N3qYMfsPj9PCCrF&index=2) -Those videos are accompanying you step by step in each exercise, but if you want to check right away all the notions covered in the quest, you can watch the whole playlist [Web - HTML, CSS & DOM JS](https://www.youtube.com/playlist?list=PLHyAJ_GrRtf979iZZ1N3qYMfsPj9PCCrF). +Those videos are accompanying you step by step in each exercise, but if you want to check right away all the notions covered in the quest, you can watch the whole playlist throughout your next exercices[Web - HTML, CSS & DOM JavaScript](https://www.youtube.com/playlist?list=PLHyAJ_GrRtf979iZZ1N3qYMfsPj9PCCrF). > Your working environment may not be exactly the same as what you see in the videos or documentation, just try to adapt your work according to your research and discoveries. > Don't be afraid to try! @@ -36,8 +35,8 @@ Ready? Let's code! > The first step to achieve in your quest is to craft the shape of your robot ; for that, 2 things needs to be done: > -> - Custumize the( [``](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/head) tag) -> - Custumize the ([``](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title) tag) +> - Customize the( [`<head>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/head) tag) +> - Customize the ([`<title>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title) tag) To create any project, some things need to be declared in the HTML file - those are not visible elements in your page, but things cannot work without them. @@ -55,8 +54,7 @@ Choose a power that you will give to your robot from the following list and put This section contains the content of your webpage , in our case the lower body of your buddy. Define the skeleton of your robot by organizing it into three main sections: the face, the upper body, and the lower body. Inside the <body> tag of your HTML file, create three divisions using <section> tags, and place the following text content inside each one: face, upper-body, lower-body. -> Don't forget to press Render again to refresh the display page when you modify your code. -> You can also see javascript code in the console at the bottom of the page, as in the previous quest. +> Don't forget to press Render again to refresh the display page when you modify your code. ### Code examples