From 8a2005e9307e65e76c46c0f1b4f0f3fc66f7f80f Mon Sep 17 00:00:00 2001 From: Urmas Rist Date: Fri, 21 Jan 2022 07:41:15 +0200 Subject: [PATCH 1/4] has-city: Specify type of paramaters/return values Also some grammar fixes. --- subjects/has-city/README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/subjects/has-city/README.md b/subjects/has-city/README.md index dbbf0add..d0d65938 100644 --- a/subjects/has-city/README.md +++ b/subjects/has-city/README.md @@ -2,10 +2,10 @@ ### Instructions -Create a function `hasCity` that takes a country and an array of cities -of that country and it returns a new function. \ -The new function takes a city parameter which returns -whether a city is part of that country or not. +Create a function `hasCity` that takes a string called `country` and a array of strings named `cities`, +which contains the cities of that country and it returns a new function. \ +The new function takes a string called `city` as a parameter which returns +whether the string is part of the `cities` array or not. -If it is, it should be returned ` is a city from `, otherwise +If it is, it should return the string ` is a city from `, otherwise ` is not a city from `. From b8238bd9b8c39fe6866301d411f9edaf72547859 Mon Sep 17 00:00:00 2001 From: Urmas Rist Date: Fri, 21 Jan 2022 07:44:32 +0200 Subject: [PATCH 2/4] sentence cleanup --- subjects/has-city/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subjects/has-city/README.md b/subjects/has-city/README.md index d0d65938..242b21b4 100644 --- a/subjects/has-city/README.md +++ b/subjects/has-city/README.md @@ -3,7 +3,7 @@ ### Instructions Create a function `hasCity` that takes a string called `country` and a array of strings named `cities`, -which contains the cities of that country and it returns a new function. \ +which returns a new function. \ The new function takes a string called `city` as a parameter which returns whether the string is part of the `cities` array or not. From 6f97733ef0f072db2bf54b004cf5b25df98b2890 Mon Sep 17 00:00:00 2001 From: Urmas Rist Date: Fri, 21 Jan 2022 08:01:49 +0200 Subject: [PATCH 3/4] more grammar cleanup --- subjects/has-city/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/subjects/has-city/README.md b/subjects/has-city/README.md index 242b21b4..e9dc7eda 100644 --- a/subjects/has-city/README.md +++ b/subjects/has-city/README.md @@ -2,10 +2,10 @@ ### Instructions -Create a function `hasCity` that takes a string called `country` and a array of strings named `cities`, +Create a function `hasCity` that takes a string called `country` and a array of strings, which returns a new function. \ -The new function takes a string called `city` as a parameter which returns -whether the string is part of the `cities` array or not. +The new function takes a string, called `city`, as a parameter and which determines +whether the array contains that string or not. -If it is, it should return the string ` is a city from `, otherwise +If it does, it should return the string ` is a city from `, otherwise ` is not a city from `. From fd16b89c169d0c8c181d9de91543966f03ae348e Mon Sep 17 00:00:00 2001 From: MSilva95 <53977751+MSilva95@users.noreply.github.com> Date: Mon, 24 Jan 2022 10:14:13 +0000 Subject: [PATCH 4/4] Update README.md small change --- subjects/has-city/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/subjects/has-city/README.md b/subjects/has-city/README.md index e9dc7eda..94fd2805 100644 --- a/subjects/has-city/README.md +++ b/subjects/has-city/README.md @@ -2,8 +2,7 @@ ### Instructions -Create a function `hasCity` that takes a string called `country` and a array of strings, -which returns a new function. \ +Create a function `hasCity` that takes a string called `country` and an array of strings, which are cities of that country, which returns a new function. \ The new function takes a string, called `city`, as a parameter and which determines whether the array contains that string or not.