From 234b715d4d868d76908d2475f26920ed474b7503 Mon Sep 17 00:00:00 2001 From: OGordoo Date: Mon, 23 Dec 2019 16:55:30 +0000 Subject: [PATCH] fixes questions --- subjects/tetrisoptimizer.audit.en.md | 33 +++++++++++++--------------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md index 10b6aa62e..a2435c000 100644 --- a/subjects/tetrisoptimizer.audit.en.md +++ b/subjects/tetrisoptimizer.audit.en.md @@ -1,6 +1,6 @@ #### Functional Project Questions -##### Try bad example 00 (github.com/public/subject/badexample00.md). +##### Try bad example 00 (github.com/public/subject/badexample00.md). `ERROR` ###### Does the program prints the value above? ##### Try bad example 01 (github.com/public/subject/badexample01.md). @@ -19,25 +19,26 @@ `ERROR` ###### Does the program prints the value above? ##### Try good example 00 (github.com/public/subject/goodexample00.md). -###### Does the result contain 0 empty spaces (0 '.') ? +###### Does the result contain 0 empty spaces (0 '.')? ##### Try good example 01 (github.com/public/subject/goodexample01.md). -###### Does the result contain 9 empty spaces (9 '.') ? +###### Does the result contain 9 empty spaces (9 '.')? ##### Try good example 02 (github.com/public/subject/goodexample02.md). -###### Does the result contain 4 empty spaces (4 '.') ? +###### Does the result contain 4 empty spaces (4 '.')? ##### Try good example 03 (github.com/public/subject/goodexample03.md). -###### Does the result contain 5 empty spaces (5 '.') ? +###### Does the result contain 5 empty spaces (5 '.')? ##### Try hard example (github.com/public/subject/hardexam.md). -###### Does the result contain 1 empty spaces (1 '.') ? -##### Are all of the Tetrominos contained in the test file, present in the output? -##### Different characters correspond to different Tetrominos? -##### Does one Tetromino has only one character? +###### Does the result contain 1 empty spaces (1 '.')? +###### Are all of the Tetrominos contained in the test file, present in the output? +###### Different characters correspond to different Tetrominos? +###### Does one Tetromino has only one character? #### Basic ###### *Has the code passed the formatting? (gofmt, goimports) +###### *Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? -###### *Does the program avoid the use of packages? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) -###### *Does the code present commenting ? +###### *Does the program avoid the use of packages? +###### *Does the code present commenting? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) ###### *Does the code present documentation? ###### *Does it present consistent indentation? ###### *Does the code avoid obvious comments (no over information)? @@ -49,17 +50,13 @@ ###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? ###### *Does the code present a good file and folder organization? ###### *Does it present a good separation of Code and Data? -###### *Does the go code follow the go recommendations? ((https://golang.org/doc/effective_go.html), (https://golang.org/cmd/gofmt/), (https://godoc.org/golang.org/x/tools/cmd/goimports), (https://goinbigdata.com/goimports-vs-gofmt/)) +###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) ###### *Is there a test file for this code? -###### *Are the tests checking each case? - +###### *Are the tests checking each possible case? ###### *Is the error handled, is it error free? -###### *Does the project runs quickly and effectively (Favoring of recursivity, no unnecessary data requests, etc.)? - #### Social -###### *Can the project be used for a common good? ###### *Did you learn anything from this project? -###### *Would you recommend/nominate this program as an example for the rest of the school? \ No newline at end of file +###### *Would you recommend/nominate this program as an example for the rest of the school?