From c4dc5636f012c173288cbe50e6b05af898f57f5d Mon Sep 17 00:00:00 2001 From: lee Date: Fri, 10 Jan 2020 16:31:40 +0000 Subject: [PATCH] reviewed and good to merge --- .../groupie-trackers.audit.en.md | 19 ++++++++----------- .../groupie-trackers/groupie-trackers.en.md | 10 +++++----- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/subjects/groupie-trackers/groupie-trackers.audit.en.md b/subjects/groupie-trackers/groupie-trackers.audit.en.md index 762adb643..b5bb243e8 100644 --- a/subjects/groupie-trackers/groupie-trackers.audit.en.md +++ b/subjects/groupie-trackers/groupie-trackers.audit.en.md @@ -4,7 +4,7 @@ ###### Is data from the relations being used? -##### Try to see the "members" for the band `"Queen"` +##### Try to see the "members" for the artist/band `"Queen"` ``` "Freddie Mercury", "Brian May", @@ -16,13 +16,13 @@ ``` ###### Does it present the right "member", as above? -##### Try to see the "firstAlbum" for the band `"Gorillaz"` +##### Try to see the "firstAlbum" for the artist/band `"Gorillaz"` ``` "26-03-2001" ``` ###### Does it present the right date for the "firstAlbum", as above? -##### Try to see the "locations" for the band `"Travis Scott"` +##### Try to see the "locations" for the artist/band `"Travis Scott"` ``` "las_vegas-usa" "brooklyn-usa" @@ -35,7 +35,7 @@ ``` ###### Does it present the right "locations" as above? -##### Try to see the ""members"" for the band `"Foo Fighters"`. +##### Try to see the ""members"" for the artist/band `"Foo Fighters"`. ``` "Dave Grohl" "Nate Mendel" @@ -46,9 +46,9 @@ ``` ###### Does it present the right members as above? -##### Try to trigger an event using some kind of action, (ex: Clicking the mouse over a certain element, hovering the cursor over a certain element. Pressing a key on the keyboard. Resizing or closing the browser window. A form being submitted. A video being played, or paused, or finishing play. An error occurring. Etc) - +##### Try to trigger an event using some kind of action (ex: Clicking the mouse over a certain element, pressing a key on the keyboard, resizing or closing the browser window, a form being submitted, an error occurring, etc). ###### Does the event responds as expected? + ###### Did the server crashed? ###### Does the server use the right [HTTP method](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods)? ###### Has the website runned without crashing at anytime? @@ -60,15 +60,12 @@ #### General -###### +Does the event system run as asynchronous? Does the code present go routines or channels? -###### +Is the site hosted or deployed? Can you access the website through a DNS (Domain Name System)? +###### +Does the event system run as asynchronous? (usage of go routines and channels) +###### +Is the site hosted or deployed? Can you access the website through a DNS (Domain Name System)? #### Basic ###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? -###### +Are the instructions in the website clear? -###### +Does the project run using an API? -###### +Can you export in multiple formats? #### Social diff --git a/subjects/groupie-trackers/groupie-trackers.en.md b/subjects/groupie-trackers/groupie-trackers.en.md index 2341ace01..1601ec059 100644 --- a/subjects/groupie-trackers/groupie-trackers.en.md +++ b/subjects/groupie-trackers/groupie-trackers.en.md @@ -2,19 +2,19 @@ ### Objectives -Groupie Trackers consists on receiving a given API and manipulate the data contained in it, in order to create a site, displaying all or part of the information. +Groupie Trackers consists on receiving a given API and manipulate the data contained in it, in order to create a site, displaying the information. - It will be given an [API](https://groupietrackers.herokuapp.com/api), that consists in four parts: - - The first one, `artists`, containing information about some bands and artists like their name(s), image, in which year they began their activity and the date of their first album. + - The first one, `artists`, containing information about some bands and artists like their name(s), image, in which year they began their activity, the date of their first album and the members. - The second one, `locations`, consists in their last and/or upcoming concert locations. - The third one, `dates`, consists in their last and/or upcoming concert dates. - - And the last one, `relations`, does the link between all the other parts, `artists`, `dates` and `locations`. + - And the last one, `relation`, does the link between all the other parts, `artists`, `dates` and `locations`. -- It should be used at least the `artists` and `relations` parts given in the API. +- It should be used at least the `artists` and the `relation` parts given in the API. - Given all this you should build a user friendly website where you can display the bands info through several data visualizations (examples : blocks, cards, tables, list, pages, graphics, etc). It is up to you to decide which info you will present and how you will display it. @@ -38,4 +38,4 @@ This project will help you learn about : ### Usage -- You can see an example of a RESTapi [here](https://rickandmortyapi.com/) +- You can see an example of a RESTful API [here](https://rickandmortyapi.com/)