From d0e33e45917a8e78bac7a07817909eb6d27c1a1e Mon Sep 17 00:00:00 2001 From: Christopher Fremond Date: Mon, 20 Jan 2020 17:19:42 +0000 Subject: [PATCH] typo fix --- .../ascii-art/ascii-art-justify.audit.en.md | 37 +++++++++++---- subjects/my-ls-1/my-ls-1.audit.en.md | 47 +++++++++++++------ subjects/push-swap/push-swap.audit.en.md | 34 ++++++++++++-- 3 files changed, 91 insertions(+), 27 deletions(-) diff --git a/subjects/ascii-art/ascii-art-justify.audit.en.md b/subjects/ascii-art/ascii-art-justify.audit.en.md index aa4f57215..1c5c19fcb 100644 --- a/subjects/ascii-art/ascii-art-justify.audit.en.md +++ b/subjects/ascii-art/ascii-art-justify.audit.en.md @@ -1,50 +1,67 @@ #### Functional Project Questions ##### Try passing as arguments `"left standard --align=right"` -###### Does it displays the correct result at the right side? + +###### Does it display the correct result at the right side? ##### Try passing as arguments `"right standard --align=left"` -###### Does it displays the correct result at the left side? + +###### Does it display the correct result at the left side? ##### Try passing as arguments `"hello shadow --align=center"` -###### Does it displays the correct result at the center? + +###### Does it display the correct result at the center? ##### Try passing as arguments `""1 Two 4" shadow --align=justify"` -###### Does it displays the correct result justified? + +###### Does it display the correct result justified? ##### Try passing as arguments `"23/32 standard --align=right"` -###### Does it displays the correct result at the right side? + +###### Does it display the correct result at the right side? ##### Try passing as arguments `"ABCabc123 thinkertoy--align=right"` -###### Does it displays the correct result at the right side? + +###### Does it display the correct result at the right side? ##### Try passing as arguments `"!#$%&" thinkertoy --align=cente"` -###### Does it displays the correct result at the center? + +###### Does it display the correct result at the center? ##### Try passing as arguments `""23Hello World!" standard --align=left"` -###### Does it displays the correct result at the left side? + +###### Does it display the correct result at the left side? ##### Try passing as arguments `""HELLO there HOW are YOU?!" thinkertoy --align=justify"` -###### Does it displays the correct result justified? + +###### Does it display the correct result justified? ##### Try passing as arguments `""a -> A b -> B c -> C" shadow --align=right"` -###### Does it displays the correct result at the right side? + +###### Does it display the correct result at the right side? ##### Try reducing the terminal window and run `"abcd shadow --align=right"` + ###### Does the representation adapt to the terminal size displaying the right result in the right side? ##### Try reducing the terminal window and run `"ola standard --align=center"` + ###### Does the representation adapt to the terminal size displaying the right result in the right side? #### Basic ###### +Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? + ###### +Is the output of the program well structured? Does any letter seems to be out of line? + ###### +Is there a test file for this code? + ###### +Are the tests checking each possible case? + ###### +Does the code obey the [good practices](https://public.01-edu.org/subjects/good-practices.en)? #### Social ###### +Did you learn anything from this project? + ###### +Would you recommend/nominate this program as an example for the rest of the school? diff --git a/subjects/my-ls-1/my-ls-1.audit.en.md b/subjects/my-ls-1/my-ls-1.audit.en.md index fa8139df9..90c5e7e9b 100644 --- a/subjects/my-ls-1/my-ls-1.audit.en.md +++ b/subjects/my-ls-1/my-ls-1.audit.en.md @@ -1,62 +1,81 @@ #### Functional ##### Run both my-ls-1 and the system command `ls` with no arguments. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the arguments: ``. -###### Does it displays the same file? + +###### Does it display the same file? ##### Run both my-ls-1 and the system command `ls` with the arguments: ``. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the flag: `-l`. -###### Does it displays the same files and/or folders with the same display? + +###### Does it display the same files and/or folders with the same display? ##### Run both my-ls-1 and the system command `ls` with the arguments: `-l `. -###### Does it displays the same file with the same display? + +###### Does it display the same file with the same display? ##### Run both my-ls-1 and the system command `ls` with the arguments: `-l `. -###### Does it displays the same files and/or folders with the same display? + +###### Does it display the same files and/or folders with the same display? ##### Run both my-ls-1 and the system command `ls` with the flag: `-l /usr/bin`. -###### Does it displays the same files and/or folders with the same display? Be aware of symbolic links. + +###### Does it display the same files and/or folders with the same display? Be aware of symbolic links. ##### Run both my-ls-1 and the system command `ls` with the flag: `-R`, in a directory with folders in it. -###### Does it displays the same files and/or folders? + +###### Does it display the same files and/or folders? ##### Run both my-ls-1 and the system command `ls` with the flag: `-a`. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the flag: `-r`. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the flag: `-t`. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the flag: `-la`. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the arguments: `-l -t `. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? ##### Run both my-ls-1 and the system command `ls` with the arguments: `-lRr `, in which the directory chosen contains folders. -###### Does it displays the same files and/or folders in the same order? + +###### Does it display the same files and/or folders in the same order? #### General ###### +Does the program runs with colors as in the ls command? + ###### +Does the program has other flags except for the mandatory ones? ##### Try running the program with `-R ~` and with the command time before the program name (ex: "time ./my-ls-1 -R ~"). + ###### +Is the real time less than 1,5 seconds? #### Basic ###### +Does the code obey the [good practices](https://public.01-edu.org/subjects/good-practices.en)? + ###### +Is there a test file for this code? + ###### +Are the tests checking each possible case? #### Social ###### +Did you learn anything from this project? + ###### +Would you recommend/nominate this program as an example for the rest of the school? diff --git a/subjects/push-swap/push-swap.audit.en.md b/subjects/push-swap/push-swap.audit.en.md index 79c30b687..855bcb8c7 100644 --- a/subjects/push-swap/push-swap.audit.en.md +++ b/subjects/push-swap/push-swap.audit.en.md @@ -1,69 +1,97 @@ #### Functional ##### Try to run `"./push_swap"`. + ###### Does it display nothing? + ##### Try to run `"./push_swap 2 1 3 6 5 8"`. + ###### Does it display a valid solution and less than 9 instructions? + ##### Try to run `"./push_swap 0 1 2 3 4 5"`. + ###### Does it display nothing? + ##### Try to run `"./push_swap 0 one 2 3"`. + ``` Error ``` + ###### Does it display the right result as above? + ##### Try to run `"./push_swap 1 2 2 3"`. + ``` Error ``` + ###### Does it display the right result as above? ##### Try to run `"./push_swap <5 random numbers>"` with 5 random numbers instead of the tag. -###### Does it displays a valid solution and less than 12 instructions? + +###### Does it display a valid solution and less than 12 instructions? ##### Try to run `"./checker "` and input nothing. + ###### Does it display nothing? ##### Try to run `"./checker 0 one 2 3"`. + ``` Error ``` + ###### Does it display the right result as above? ##### Try to run `"echo -e "sa\npb\nrrr\n" | ./checker 0 9 1 8 2 7 3 6 4 5"`. + ``` KO ``` + ###### Does it display the right result as above? ##### Try to run `"echo -e "pb\nra\npb\nra\nsa\nra\npa\npa\n" | ./checker 0 9 1 8 2"`. + ``` OK ``` + ###### Does it display the right result as above? ##### Try to run `"ARG = "4 67 3 87 23"; ./push_swap $ARG | ./checker $ARG"`. + ``` OK ``` + ###### Does it display the right result as above? #### General ##### Try to run `"$ARG= "<100 random numbers>"; ./push_swap $ARG"` with 100 random different numbers instead of the tag. -###### +Does it displays less than 700 commands? + +###### +Does it display less than 700 commands? + ##### Try to run `"$ARG= "<100 random numbers>; ./push_swap $ARG | ./checker $ARG"` with the same 100 random different numbers as before instead of the tag. + ``` OK ``` -###### +Does it displays the right result as above? + +###### +Does it display the right result as above? #### Basic ###### +Does the code obey the [good practices](https://public.01-edu.org/subjects/good-practices.en)? + ###### +Is there a test file for this code? + ###### +Are the tests checking each possible case? #### Social ###### +Did you learn anything from this project? + ###### +Would you recommend/nominate this program as an example for the rest of the school?