From f4c37fb206a071f15b5e75ce129c4ba594486deb Mon Sep 17 00:00:00 2001 From: OGordoo Date: Mon, 20 Jan 2020 11:24:31 +0000 Subject: [PATCH] reviewing projects --- .../ascii-art-web-dockerize.audit.en.md | 4 ++-- subjects/ascii-art/ascii-art-color.en.md | 2 +- .../groupie-trackers-search-bar.audit.en.md | 12 ++++++++++++ .../groupie-trackers-search-bar.en.md | 10 +++++----- subjects/net-cat/net-cat.audit.en.md | 4 ++-- subjects/net-cat/net-cat.en.md | 16 ++++++++-------- 6 files changed, 30 insertions(+), 18 deletions(-) diff --git a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md index c803eab78..8f280f039 100644 --- a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md @@ -2,7 +2,7 @@ ###### Does the project have a DockerFile? -##### Try running the [command](https://docs.docker.com/engine/reference/commandline/image_build/) `"docker image build [OPTIONS] PATH | URL | -"` to build the image. (example : `"docker image build -f Dockerfile -t ."`). +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/image_build/) `"docker image build [OPTIONS] PATH | URL | -"` to build the image using the project Dockerfile. (example : `"docker image build -f Dockerfile -t ."`). ``` student$ docker images REPOSITORY TAG IMAGE ID CREATED SIZE @@ -10,7 +10,7 @@ REPOSITORY TAG IMAGE ID CREA ``` ###### Run the command `"docker images"` to see all images. Does the docker image build as above? -##### Try running the [command](https://docs.docker.com/engine/reference/commandline/container_run/) `"docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]"` to start the container. (example : `"docker container run -p --detach --name "`) +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/container_run/) `"docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]"` to start the container using the image just created. (example : `"docker container run -p --detach --name "`) ``` student$ docker ps -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES diff --git a/subjects/ascii-art/ascii-art-color.en.md b/subjects/ascii-art/ascii-art-color.en.md index 98d156098..8b8cb80ed 100644 --- a/subjects/ascii-art/ascii-art-color.en.md +++ b/subjects/ascii-art/ascii-art-color.en.md @@ -4,7 +4,7 @@ You must follow the same [instructions](https://public.01-edu.org/subjects/ascii-art/ascii-art.en) as in the first subject but with colors. -- The output should manipulate colors using the **flag** `--color=`, in which `--color` is the flag and `` is the color of choice. +- The output should manipulate colors using the **flag** `--color=`, in which `--color` is the flag and `` is the color name of choice (ex: orange, green, blue). - The colors must respect the [RGB](https://en.wikipedia.org/wiki/RGB_color_model) concept. - You should be able to specify a single or a set of letters you want to be colored (use your imagination for this one). - If the letter isn't specified, the whole `string` should be colored. diff --git a/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md b/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md index 5fc6be7cf..faf4fc4a3 100644 --- a/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md +++ b/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md @@ -30,6 +30,18 @@ ##### Try to search for the creation date `"1965"`. ###### Does it present as result "Scorpions" and "Pink Floyd"? +##### Start typing an artist/band beginning with `"G"`. +###### Does it present as suggestion the band you were looking for? + +##### Start typing a location of one of the concerts. +###### Does it present as suggestion the location you were looking for? + +##### Try to search for an artist/band member beginning with `"R"`. +###### Does it present the artist/band you were looking for? + +##### Try to search for a creation date of an artist/band. +###### Does it present the artist/band you were looking for? + #### Basic ###### +Does the code obey the [good practices](https://public.01-edu.org/subjects/good-practices.en)? diff --git a/subjects/groupie-trackers/groupie-trackers-search-bar.en.md b/subjects/groupie-trackers/groupie-trackers-search-bar.en.md index d3692dde3..bbdf59335 100644 --- a/subjects/groupie-trackers/groupie-trackers-search-bar.en.md +++ b/subjects/groupie-trackers/groupie-trackers-search-bar.en.md @@ -15,14 +15,14 @@ Groupie-trackers-search-bar consists of creating a functional program that searc - The program must handle case sensitive. - The search bar must have typing suggestions as you write. - The search bar must identify and display in each suggestion the individual type of the search cases. (ex: Freddie Mercury -> member) - - Example if you start writing `"phil"` it should appear as suggestions `Phil Collins - member` and `Phil Collins - artist/band`. This is just an example of a display. + - For example if you start writing `"phil"` it should appear as suggestions `Phil Collins - member` and `Phil Collins - artist/band`. This is just an example of a display. This project will help you learn about : - - Manipulation, display and storage of data. - - HTML. - - [Events](https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/) creation and display. - - JSON files and format. +- Manipulation, display and storage of data. +- HTML. +- [Events](https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/) creation and display. +- JSON files and format. ### Instructions diff --git a/subjects/net-cat/net-cat.audit.en.md b/subjects/net-cat/net-cat.audit.en.md index 0be8de0c1..cc9140f8c 100644 --- a/subjects/net-cat/net-cat.audit.en.md +++ b/subjects/net-cat/net-cat.audit.en.md @@ -16,10 +16,10 @@ ###### Does the second Client receive the message? ##### Try creating a server and 1 Client and send some messages using this Client. Then create a new Client. -###### Can the new Client see all the messages? +###### Can the new Client see all the previous messages? ##### Try creating a server and 3 Clients and send a message using the second Client. -###### Does all the Clients(first, second and third) received the same message? +###### Does all the Clients (first, second and third) received the same message? ##### Try creating a server and use 2 or 3 different computers and create for each computer one Client. ###### Did the server/Clients connected with success? diff --git a/subjects/net-cat/net-cat.en.md b/subjects/net-cat/net-cat.en.md index 0540771e8..f83326a0b 100644 --- a/subjects/net-cat/net-cat.en.md +++ b/subjects/net-cat/net-cat.en.md @@ -2,9 +2,9 @@ ### Objectives -This project consists on recreating the **NetCat in a Server-Client Architecture** that can run in a server mode on a specified port listening for incoming connections, and it can be used in client mode, trying to connect on a specified port and transmitting information to the server. +This project consists on recreating the **NetCat in a Server-Client Architecture** that can run in a server mode on a specified port listening for incoming connections, and it can be used in client mode, trying to connect to a specified port and transmitting information to the server. -- NetCat, `nc` the system command, is a computer network utility for reading from and writing to network connections using TCP or UDP. It is used for anything involving TCP, UDP, or UNIX-domain sockets, it is able to open TCP connections, send UDP packages, listen on arbitrary TCP and UDP ports... +- NetCat, `nc` system command, is a computer network utility for reading from and writing to network connections using TCP or UDP. It is used for anything involving TCP, UDP, or UNIX-domain sockets, it is able to open TCP connections, send UDP packages, listen on arbitrary TCP and UDP ports... - To see more information about NetCat inspect the manual `man nc`. @@ -29,15 +29,15 @@ Here is a simple example of connection and transmission between Server-Client by ``` - - To see the host IP use the command `ifconfig` on the host machine. + - To see the host IP use the command `ifconfig` on the server host machine. -Your project must work in a similar way that NetCat works, in other words you must create a group chat. The project must present : +Your project must work in a similar way that NetCat works, in other words, you must create a group chat. The project must present : -- TCP or UDP connection between server and multiple clients (relation of 1 to many), the type of connection must be established by using a flag, just like `nc`, by default it uses TCP connection, if you want to use UDP connection present the flag `-u`. +- TCP or UDP connection between server and multiple clients (relation of 1 to many). The type of connection must be established by using a flag, just like `nc`, by default it uses TCP connection, but if you want to use UDP connection present the flag `-u`. - Each Client must have an user name. - Clients must be able to send messages to the chat. - Messages sent, must be identified by the time that was sent and the user name of who sent the message. -- If a Client joins the chat, all the messages sent to the chat must be uploaded to the new Client. +- If a Client joins the chat, all the previous messages sent to the chat must be uploaded to the new Client. - If a Client connects to the server, the rest of the Clients must be informed by the server that the Client joined the group. - If a Client exits the chat, the rest of the Clients must be informed by the server that the Client left. - All Clients must receive the messages sent by other Clients. @@ -83,8 +83,8 @@ listening on port 8080.... - Client 2 : ```console -stuednt$ ./net-cat 192.168.1.123 8080 -wellcome, you are connected +student$ ./net-cat 192.168.1.123 8080 +welcome, you are connected enter user name : client2 your name is client2