From 64bd373bf751db218909b89061295c4c953ce504 Mon Sep 17 00:00:00 2001 From: lee Date: Wed, 4 Dec 2019 23:40:29 +0000 Subject: [PATCH 01/10] subject for ascii-art-web-dockerize --- subjects/ascii-art-web-dockerize.en.md | 37 ++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 subjects/ascii-art-web-dockerize.en.md diff --git a/subjects/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web-dockerize.en.md new file mode 100644 index 00000000..9491b581 --- /dev/null +++ b/subjects/ascii-art-web-dockerize.en.md @@ -0,0 +1,37 @@ +## ascii-art-web-dockerize + +### Objectives + +You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject, ascii-art-web. + +- For this project you must create at least : + - one image/Dockerfile + - one container + +This project will help you learn about : + +- Client utilities. +- The basics of web : + - Server + - HTML + - HTTP +- Ways to receive data. +- Ways to output data. +- Learning what is [docker](https://docs.docker.com). +- Using and [setting up Docker](https://docs.docker.com/get-started/) : + - Services and dependencies. + - Containerizing an application. + - Compatibility/Dependency. + - Creating images. + +### Instructions + +- The web server must be created in **Go**. +- The code must respect the [good practices](https://github.com/01-edu/public/good-practices.en.md). +- Your Dockerfile must respect the [Dockerfile good practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/). +- The project must have files written in **HTML**. +- You must use Docker. + +### Usage + +- You can see all about Docker on [docker docs](https://docs.docker.com/). From 1099462c8679f6d02d6d04a3cd41484b69abce54 Mon Sep 17 00:00:00 2001 From: lee Date: Thu, 5 Dec 2019 16:49:47 +0000 Subject: [PATCH 02/10] removing --- subjects/ascii-art-web-dockerize.en.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subjects/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web-dockerize.en.md index 9491b581..89171533 100644 --- a/subjects/ascii-art-web-dockerize.en.md +++ b/subjects/ascii-art-web-dockerize.en.md @@ -2,7 +2,7 @@ ### Objectives -You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject, ascii-art-web. +You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject. - For this project you must create at least : - one image/Dockerfile From c1a4b03cab9eb8df49aa1d635cb2646f9b0b5a41 Mon Sep 17 00:00:00 2001 From: lee Date: Wed, 4 Dec 2019 23:40:29 +0000 Subject: [PATCH 03/10] subject for ascii-art-web-dockerize --- subjects/ascii-art-web-dockerize.en.md | 37 ++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 subjects/ascii-art-web-dockerize.en.md diff --git a/subjects/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web-dockerize.en.md new file mode 100644 index 00000000..9491b581 --- /dev/null +++ b/subjects/ascii-art-web-dockerize.en.md @@ -0,0 +1,37 @@ +## ascii-art-web-dockerize + +### Objectives + +You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject, ascii-art-web. + +- For this project you must create at least : + - one image/Dockerfile + - one container + +This project will help you learn about : + +- Client utilities. +- The basics of web : + - Server + - HTML + - HTTP +- Ways to receive data. +- Ways to output data. +- Learning what is [docker](https://docs.docker.com). +- Using and [setting up Docker](https://docs.docker.com/get-started/) : + - Services and dependencies. + - Containerizing an application. + - Compatibility/Dependency. + - Creating images. + +### Instructions + +- The web server must be created in **Go**. +- The code must respect the [good practices](https://github.com/01-edu/public/good-practices.en.md). +- Your Dockerfile must respect the [Dockerfile good practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/). +- The project must have files written in **HTML**. +- You must use Docker. + +### Usage + +- You can see all about Docker on [docker docs](https://docs.docker.com/). From a163568691e2abde17e51e37725b7ea3bea923d3 Mon Sep 17 00:00:00 2001 From: lee Date: Thu, 5 Dec 2019 16:49:47 +0000 Subject: [PATCH 04/10] removing --- subjects/ascii-art-web-dockerize.en.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subjects/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web-dockerize.en.md index 9491b581..89171533 100644 --- a/subjects/ascii-art-web-dockerize.en.md +++ b/subjects/ascii-art-web-dockerize.en.md @@ -2,7 +2,7 @@ ### Objectives -You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject, ascii-art-web. +You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject. - For this project you must create at least : - one image/Dockerfile From 439c34bc8ff87d1255f70962dc524bc1af3d2290 Mon Sep 17 00:00:00 2001 From: lee Date: Mon, 30 Dec 2019 18:30:32 +0000 Subject: [PATCH 05/10] ascii-art-web questions and fixes --- .../ascii-art-web-dockerize.audit.en.md | 56 +++++++++++ .../ascii-art-web-dockerize.en.md | 13 ++- .../ascii-art-web/ascii-art-web.audit.en.md | 98 +++++++++++++++++++ subjects/good-practices.en.md | 4 + 4 files changed, 167 insertions(+), 4 deletions(-) create mode 100644 subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md rename subjects/{ => ascii-art-web}/ascii-art-web-dockerize.en.md (65%) create mode 100644 subjects/ascii-art-web/ascii-art-web.audit.en.md diff --git a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md new file mode 100644 index 00000000..a2e81a6c --- /dev/null +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md @@ -0,0 +1,56 @@ +#### Functional Project Questions + +###### Does the project present a DockerFile? + +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/image_build/) `docker image build [OPTIONS] PATH | URL | -` to build the image. (example : `docker image build -f Dockerfile -t .`). +``` +student$ docker images +REPOSITORY TAG IMAGE ID CREATED SIZE + latest 85a65d66ca39 7 seconds ago 795MB +``` +###### Run the command `docker images` to see all images. Does the docker image build as above? + +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/container_run/) `docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]` to start the container. (example : `docker container run -p --detach --name `) +``` +student$ docker ps -a +CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES +cc8f5dcf760f ascii-art-web-docker "./server" 6 seconds ago Up 6 seconds 0.0.0.0:8080->8080/tcp ascii-art-web +``` +###### Run the command `docker ps -a` to see all containers. Is the docker container running as above? + +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/exec/) `docker exec [OPTIONS] CONTAINER COMMAND [ARG...]`. (example : `docker exec -it /bin/bash`) and do a `ls -l` to see the file system. +``` +student$ docker exec -it postgres /bin/bash +I have no name!@51c2efe2d366:/$ ls -l +drwxr-xr-x 1 root root 4096 Dec 28 15:31 bin +-rwxr-xr-x 2 root root 4096 Sep 8 10:51 server.go +drwxr-xr-x 2 root root 4096 Sep 8 10:51 templates +I have no name!@51c2efe2d366:/$ exit +exit +``` +###### Is the file system for the containers well organized? + +###### Does the DockerFile contain some [metadata](https://docs.docker.com/config/labels-custom-metadata/) applied to the docker object? + +###### Does the project present no [unused object](https://docs.docker.com/config/pruning/)? + +#### General Requirements + +###### +Does the project present a script to build the images and containers? (using a script to simplify the build) + +#### Basic + +###### +Does the server run quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) +###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? + +###### +Is there a test file for this code? +###### +Are the tests checking each possible case? + +###### +Are the instructions in the website clear? +###### +Does the project run using an API? + +#### Social + +###### +Did you learn anything from this project? +###### +Can it be open-sourced / be used for other sources? +###### +Would you recommend/nominate this program as an example for the rest of the school? diff --git a/subjects/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.en.md similarity index 65% rename from subjects/ascii-art-web-dockerize.en.md rename to subjects/ascii-art-web/ascii-art-web-dockerize.en.md index 89171533..a83f23c2 100644 --- a/subjects/ascii-art-web-dockerize.en.md +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.en.md @@ -2,12 +2,17 @@ ### Objectives -You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject. +You must follow the same [principles](https://github.com/01-edu/public/blob/master/subjects/ascii-art-web/ascii-art-web.en.md) as the first subject. - For this project you must create at least : - - one image/Dockerfile + - one Dockerfile + - one image - one container +- You must apply [metadata](https://docs.docker.com/config/labels-custom-metadata/) to Docker objects. + +- You have to take caution of unused object (often referred to as "garbage collection"). + This project will help you learn about : - Client utilities. @@ -27,9 +32,9 @@ This project will help you learn about : ### Instructions - The web server must be created in **Go**. -- The code must respect the [good practices](https://github.com/01-edu/public/good-practices.en.md). +- The code must respect the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md). +- The project must have a **Dockerfile**. - Your Dockerfile must respect the [Dockerfile good practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/). -- The project must have files written in **HTML**. - You must use Docker. ### Usage diff --git a/subjects/ascii-art-web/ascii-art-web.audit.en.md b/subjects/ascii-art-web/ascii-art-web.audit.en.md new file mode 100644 index 00000000..b54906b4 --- /dev/null +++ b/subjects/ascii-art-web/ascii-art-web.audit.en.md @@ -0,0 +1,98 @@ +#### Functional Project Questions + +###### Does the project contain HTML files? + +##### Try inputting "{123}\n (World)!" with the standard template/banner. +``` + __ __ + / / _ ____ _____ \ \ + | | / | |___ \ |___ / | | +/ / | | __) | |_ \ \ \ +\ \ | | / __/ ___) | / / + | | |_| |_____| |____/ | | + \_\ /_/ + + __ _ _ _ _ __ __ __ __ _ _ __ _ + / / | | | | | | | | \ \ / / \ \ / / | | | | \ \ | | + / / | |__| | ___ | | | | ___ \ \ | | \ \ /\ / / ___ _ __ | | __| | | | | | +< < | __ | / _ \ | | | | / _ \ > > | | \ \/ \/ / / _ \ | '__| | | / _` | | | | | + \ \ | | | | | __/ | | | | | (_) | / / | | \ /\ / | (_) | | | | | | (_| | | | |_| + \_\ |_| |_| \___| |_| |_| \___/ /_/ | | \/ \/ \___/ |_| |_| \__,_| | | (_) + \_\ /_/ + +``` +###### Does it display the right result as above? + +##### Try to input "123??" using the template/banner standard. +``` + ___ ___ + _ ____ _____ |__ \ |__ \ +/ | |___ \ |___ / ) | ) | +| | __) | |_ \ / / / / +| | / __/ ___) | |_| |_| +|_| |_____| |____/ (_) (_) + + +``` +###### Does it display the right result as above? + +##### Try to input "$% \"=" using the template/banner shadow. +``` + _| _| + _| _|_| _| _| _| +_|_|_| _|_| _| _|_|_|_|_| +_|_| _| + _|_| _| _|_| _|_|_|_|_| +_|_|_| _| _|_| + _| + +``` +###### Does it display the right result as above? + +##### Try to input "123 T/fs#R" using the template/banner thinkertoy. +``` + + 0 -- o-o o-O-o o o-o | | o--o + /| o o | | / | -O-O- | | +o | / oo | o -O- o-o | | O-Oo + | / | | / | \ -O-O- | \ +o-o-o o--o o-o o o o o-o | | o o + + +``` +###### Does it display the right result as above? + +###### Does it display an understandable graphical representation of the result? + +##### Try to navigate between all the available pages in the website. +###### Are all the pages working? Does the project avoid [404 status](https://www.restapitutorial.com/httpstatuscodes.html)? + +###### Does the project avoid HTTP status [400 bad request](https://kinsta.com/knowledgebase/400-bad-request/#causes)? +###### Does the project avoid HTTP status [500 internal server error](https://www.restapitutorial.com/httpstatuscodes.html)? + +##### Try making a request to the server (clicking a button to generate the ascii-art representation on the website) +###### Is the communication between [server and client](https://www.geeksforgeeks.org/client-server-model/) well established? + +###### Does the server present the right [HTTP methods](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods)? +###### Has the website runned without crashing at anytime? + +#### General Requirements + +###### +Does the server present all the needed [handlers and patterns](https://golang.org/pkg/net/http/#HandleFunc) for the http requests? + +#### Basic + +###### +Does the server run quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) +###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? + +###### +Is there a test file for this code? +###### +Are the tests checking each possible case? + +###### +Are the instructions in the website clear? +###### +Does the project run using an API? + +#### Social + +###### +Did you learn anything from this project? +###### +Can it be open-sourced / be used for other sources? +###### +Would you recommend/nominate this program as an example for the rest of the school? diff --git a/subjects/good-practices.en.md b/subjects/good-practices.en.md index c7161eec..8f5b4f7f 100644 --- a/subjects/good-practices.en.md +++ b/subjects/good-practices.en.md @@ -27,3 +27,7 @@ - [**gofmt**](https://golang.org/cmd/gofmt/) - [**goimports**](https://godoc.org/golang.org/x/tools/cmd/goimports) - [**foimports vs gofmt**](https://goinbigdata.com/goimports-vs-gofmt/) + +### Dockerfile + +- [**Dockerfile**](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/) From 0c60dd015080e6d65ef855c09f048426698815ca Mon Sep 17 00:00:00 2001 From: lee Date: Tue, 31 Dec 2019 15:55:16 +0000 Subject: [PATCH 06/10] correction of title and adding ` and " --- .../ascii-art-web-dockerize.audit.en.md | 12 ++++++------ subjects/ascii-art-web/ascii-art-web.audit.en.md | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md index a2e81a6c..febb561a 100644 --- a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md @@ -1,24 +1,24 @@ -#### Functional Project Questions +#### Functional ###### Does the project present a DockerFile? -##### Try running the [command](https://docs.docker.com/engine/reference/commandline/image_build/) `docker image build [OPTIONS] PATH | URL | -` to build the image. (example : `docker image build -f Dockerfile -t .`). +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/image_build/) `"docker image build [OPTIONS] PATH | URL | -"` to build the image. (example : `"docker image build -f Dockerfile -t ."`). ``` student$ docker images REPOSITORY TAG IMAGE ID CREATED SIZE latest 85a65d66ca39 7 seconds ago 795MB ``` -###### Run the command `docker images` to see all images. Does the docker image build as above? +###### Run the command `"docker images"` to see all images. Does the docker image build as above? -##### Try running the [command](https://docs.docker.com/engine/reference/commandline/container_run/) `docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]` to start the container. (example : `docker container run -p --detach --name `) +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/container_run/) `"docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]"` to start the container. (example : `"docker container run -p --detach --name "`) ``` student$ docker ps -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES cc8f5dcf760f ascii-art-web-docker "./server" 6 seconds ago Up 6 seconds 0.0.0.0:8080->8080/tcp ascii-art-web ``` -###### Run the command `docker ps -a` to see all containers. Is the docker container running as above? +###### Run the command `"docker ps -a"` to see all containers. Is the docker container running as above? -##### Try running the [command](https://docs.docker.com/engine/reference/commandline/exec/) `docker exec [OPTIONS] CONTAINER COMMAND [ARG...]`. (example : `docker exec -it /bin/bash`) and do a `ls -l` to see the file system. +##### Try running the [command](https://docs.docker.com/engine/reference/commandline/exec/) `"docker exec [OPTIONS] CONTAINER COMMAND [ARG...]"`. (example : `"docker exec -it /bin/bash"`) and do a `"ls -l"` to see the file system. ``` student$ docker exec -it postgres /bin/bash I have no name!@51c2efe2d366:/$ ls -l diff --git a/subjects/ascii-art-web/ascii-art-web.audit.en.md b/subjects/ascii-art-web/ascii-art-web.audit.en.md index b54906b4..91b7577a 100644 --- a/subjects/ascii-art-web/ascii-art-web.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web.audit.en.md @@ -1,8 +1,8 @@ -#### Functional Project Questions +#### Functional ###### Does the project contain HTML files? -##### Try inputting "{123}\n (World)!" with the standard template/banner. +##### Try inputting `"{123}\n (World)!"` with the standard template/banner. ``` __ __ / / _ ____ _____ \ \ @@ -23,7 +23,7 @@ ``` ###### Does it display the right result as above? -##### Try to input "123??" using the template/banner standard. +##### Try to input `"123??"` using the template/banner standard. ``` ___ ___ _ ____ _____ |__ \ |__ \ @@ -36,7 +36,7 @@ ``` ###### Does it display the right result as above? -##### Try to input "$% \"=" using the template/banner shadow. +##### Try to input `"$% \"="` using the template/banner shadow. ``` _| _| _| _|_| _| _| _| @@ -49,7 +49,7 @@ _|_|_| _| _|_| ``` ###### Does it display the right result as above? -##### Try to input "123 T/fs#R" using the template/banner thinkertoy. +##### Try to input `"123 T/fs#R"` using the template/banner thinkertoy. ``` 0 -- o-o o-O-o o o-o | | o--o From 0a55c346f913315a56454047328f545b612b83e3 Mon Sep 17 00:00:00 2001 From: lee Date: Thu, 2 Jan 2020 12:14:09 +0000 Subject: [PATCH 07/10] removing extra file --- subjects/ascii-art-web-dockerize.en.md | 37 -------------------------- 1 file changed, 37 deletions(-) delete mode 100644 subjects/ascii-art-web-dockerize.en.md diff --git a/subjects/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web-dockerize.en.md deleted file mode 100644 index 89171533..00000000 --- a/subjects/ascii-art-web-dockerize.en.md +++ /dev/null @@ -1,37 +0,0 @@ -## ascii-art-web-dockerize - -### Objectives - -You must follow the same [instructions](https://github.com/01-edu/public/ascii-art-web.en.md) as the first subject. - -- For this project you must create at least : - - one image/Dockerfile - - one container - -This project will help you learn about : - -- Client utilities. -- The basics of web : - - Server - - HTML - - HTTP -- Ways to receive data. -- Ways to output data. -- Learning what is [docker](https://docs.docker.com). -- Using and [setting up Docker](https://docs.docker.com/get-started/) : - - Services and dependencies. - - Containerizing an application. - - Compatibility/Dependency. - - Creating images. - -### Instructions - -- The web server must be created in **Go**. -- The code must respect the [good practices](https://github.com/01-edu/public/good-practices.en.md). -- Your Dockerfile must respect the [Dockerfile good practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/). -- The project must have files written in **HTML**. -- You must use Docker. - -### Usage - -- You can see all about Docker on [docker docs](https://docs.docker.com/). From e4e0eb2b8a79bfce2661cfc54dd22cef06ce7255 Mon Sep 17 00:00:00 2001 From: lee Date: Fri, 3 Jan 2020 09:55:21 +0000 Subject: [PATCH 08/10] corrections of typos --- subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md | 3 ++- subjects/ascii-art-web/ascii-art-web-dockerize.en.md | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md index febb561a..d414eaeb 100644 --- a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md @@ -1,6 +1,6 @@ #### Functional -###### Does the project present a DockerFile? +###### Does the project have a DockerFile? ##### Try running the [command](https://docs.docker.com/engine/reference/commandline/image_build/) `"docker image build [OPTIONS] PATH | URL | -"` to build the image. (example : `"docker image build -f Dockerfile -t ."`). ``` @@ -27,6 +27,7 @@ drwxr-xr-x 1 root root 4096 Dec 28 15:31 bin drwxr-xr-x 2 root root 4096 Sep 8 10:51 templates I have no name!@51c2efe2d366:/$ exit exit +student$ ``` ###### Is the file system for the containers well organized? diff --git a/subjects/ascii-art-web/ascii-art-web-dockerize.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.en.md index a83f23c2..0fb4d2be 100644 --- a/subjects/ascii-art-web/ascii-art-web-dockerize.en.md +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.en.md @@ -33,9 +33,9 @@ This project will help you learn about : - The web server must be created in **Go**. - The code must respect the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md). +- You must use Docker. - The project must have a **Dockerfile**. - Your Dockerfile must respect the [Dockerfile good practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/). -- You must use Docker. ### Usage From 62e994296ba9d560d739ae78f5528c1488cb2164 Mon Sep 17 00:00:00 2001 From: lee Date: Fri, 3 Jan 2020 10:45:39 +0000 Subject: [PATCH 09/10] adding questions --- subjects/ascii-art-web/ascii-art-web.audit.en.md | 3 ++- subjects/ascii-art-web/ascii-art-web.en.md | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/subjects/ascii-art-web/ascii-art-web.audit.en.md b/subjects/ascii-art-web/ascii-art-web.audit.en.md index 91b7577a..2cd8cdc0 100644 --- a/subjects/ascii-art-web/ascii-art-web.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web.audit.en.md @@ -73,8 +73,9 @@ o-o-o o--o o-o o o o o-o | | o o ##### Try making a request to the server (clicking a button to generate the ascii-art representation on the website) ###### Is the communication between [server and client](https://www.geeksforgeeks.org/client-server-model/) well established? -###### Does the server present the right [HTTP methods](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods)? +###### Does the server use the right [HTTP method](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods)? ###### Has the website runned without crashing at anytime? +###### Is the server written in Go? #### General Requirements diff --git a/subjects/ascii-art-web/ascii-art-web.en.md b/subjects/ascii-art-web/ascii-art-web.en.md index 95aefc07..791e76bd 100644 --- a/subjects/ascii-art-web/ascii-art-web.en.md +++ b/subjects/ascii-art-web/ascii-art-web.en.md @@ -8,6 +8,7 @@ Ascii-art-web consists in creating and running a server, in which it will be pos - You can run your server **locally** (localhost) or using an **API**. - You must use the different [banners](https://github.com/01-edu/public/tree/master/subjects/ascii-art) for the website. - It should be available to choose between the banners. +- You have to use the right [HTTP methods](https://www.tutorialspoint.com/http/http_methods.htm). - You need to have a well established connection between server and client. This project will help you learn about : From 506cf3be178493e71ca9654f7006570c20d4e602 Mon Sep 17 00:00:00 2001 From: lee Date: Fri, 3 Jan 2020 11:06:34 +0000 Subject: [PATCH 10/10] replacing title --- subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md | 2 +- subjects/ascii-art-web/ascii-art-web.audit.en.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md index d414eaeb..e5c82912 100644 --- a/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web-dockerize.audit.en.md @@ -35,7 +35,7 @@ student$ ###### Does the project present no [unused object](https://docs.docker.com/config/pruning/)? -#### General Requirements +#### General ###### +Does the project present a script to build the images and containers? (using a script to simplify the build) diff --git a/subjects/ascii-art-web/ascii-art-web.audit.en.md b/subjects/ascii-art-web/ascii-art-web.audit.en.md index 2cd8cdc0..77b59ea8 100644 --- a/subjects/ascii-art-web/ascii-art-web.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web.audit.en.md @@ -77,7 +77,7 @@ o-o-o o--o o-o o o o o-o | | o o ###### Has the website runned without crashing at anytime? ###### Is the server written in Go? -#### General Requirements +#### General ###### +Does the server present all the needed [handlers and patterns](https://golang.org/pkg/net/http/#HandleFunc) for the http requests?