Browse Source

replacing * -> + and removing questions

content-update
lee 5 years ago
parent
commit
9257482717
  1. 36
      subjects/ascii-art/ascii-color.audit.en.md

36
subjects/ascii-art/ascii-color.audit.en.md

@ -19,36 +19,18 @@
#### General Requirements
##### *Is it easy/intuitive to specify letter(s) to be coloured?
##### *Can you use more than one color in the same string?
##### +Is it easy/intuitive to specify letter(s) to be coloured?
##### +Can you use more than one color in the same string?
#### Basic
###### *Has the code passed the formatting? (gofmt, goimports)
###### *Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc)
###### *Does the code present commenting? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)
###### *Does the code present documentation?
###### *Does it present consistent indentation?
###### *Does the code avoid obvious comments (no over information)?
###### *Does the code avoid code grouping?
###### *Does the code have a consistent naming scheme (camelCase, under_scores)?
###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)?
###### *Does the code obey the principal "KISS" (keep it simple, stupid)?
###### *Does the code obey the principle "YAGNI" (You Are not Gonna Need It)?
###### *Does the code obey the principle "SOC" (Separation of Concerns)?
###### *Does the code avoid deep nesting (if in ifs, forest of ifs)?
###### *Does the code present a good file and folder organization?
###### *Does it present a good separation of Code and Data?
###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)
###### *Is the error handled, is it error free?
###### *Is there a test file for this code?
###### *Are the tests checking each case possible?
###### *Is the output of the program well structured? Does any letter seems to be out of line?
###### +Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)?
###### +Is the output of the program well structured? Does any letter seems to be out of line?
###### +Is there a test file for this code?
###### +Are the tests checking each possible case?
###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)?
#### Social
###### *Did you learn anything from this project?
###### *Can it be open-sourced / be used for other sources?
###### *Would you recommend/nominate this program as an example for the rest of the school?
###### +Did you learn anything from this project?
###### +Would you recommend/nominate this program as an example for the rest of the school?

Loading…
Cancel
Save