From 7b5af2220aeabfc21e7ee4f3e56cf1ed7b6b9a6e Mon Sep 17 00:00:00 2001 From: MSilva95 Date: Mon, 30 Dec 2019 18:46:47 +0000 Subject: [PATCH 1/2] questions for ascii-web export files --- .../ascii-art-web-exportfile.audit.en.md | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md diff --git a/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md b/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md new file mode 100644 index 00000000..3c47db11 --- /dev/null +++ b/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md @@ -0,0 +1,25 @@ +#### Functional Project Questions + +##### Try to export the file. +###### Does the exported file matches the output? + +##### Try to open and change the exported file. +###### Are the exported files read and write for the user only? + +###### Does the site has a clear buton/link to download/export the file? + +##### Try to export a file with multiple lines. +###### Can you export a file with multiple lines? + +#### Basic + +###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? +###### +Are the instructions in the website clear? +###### +Does the project run using an API? +###### +Can you export in multiple formats? + +#### Social + +###### +Did you learn anything from this project? +###### +Can it be open-sourced / be used for other sources? +###### +Would you recommend/nominate this program as an example for the rest of the school? \ No newline at end of file From a7c94a7ba790bd6bfc177bf6146b6923bbbbd5f5 Mon Sep 17 00:00:00 2001 From: lee Date: Tue, 31 Dec 2019 18:39:44 +0000 Subject: [PATCH 2/2] adding questions and correnctions --- .../ascii-art-web-exportfile.audit.en.md | 12 ++++++++---- .../ascii-art-web/ascii-art-web-exportfile.en.md | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md b/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md index 3c47db11..79431fd7 100644 --- a/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md +++ b/subjects/ascii-art-web/ascii-art-web-exportfile.audit.en.md @@ -1,4 +1,5 @@ -#### Functional Project Questions +#### Functional + ##### Try to export the file. ###### Does the exported file matches the output? @@ -6,10 +7,13 @@ ##### Try to open and change the exported file. ###### Are the exported files read and write for the user only? -###### Does the site has a clear buton/link to download/export the file? +###### Does the project use the HTTP header [Content-Type](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type) to indicate the media type of the resource? + +###### Does the project use the HTTP header [Content-Length](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Length) to indicate the size of the entity-body, in bytes, sent to the recipient? + +###### Does the project use the HTTP header [Content-Disposition](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition) to download the files? -##### Try to export a file with multiple lines. -###### Can you export a file with multiple lines? +###### Does the site has a clear button/link to download/export the file? #### Basic diff --git a/subjects/ascii-art-web/ascii-art-web-exportfile.en.md b/subjects/ascii-art-web/ascii-art-web-exportfile.en.md index 1de88e04..54e0a666 100644 --- a/subjects/ascii-art-web/ascii-art-web-exportfile.en.md +++ b/subjects/ascii-art-web/ascii-art-web-exportfile.en.md @@ -15,6 +15,7 @@ This project will help you learn about : - Portable Document Format (pdf) - Text File (txt) - [Here are some more examples](https://en.wikipedia.org/wiki/Document_file_format) +- HTTP headers - Ways to receive data. - Ways to output data.