vcaw
/
public
forked from root/public
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

removing '*' and fixing linkto good practices

content-update
lee 5 years ago
parent
bd0bd2248e
commit
cb67ca369d
2 changed files with 16 additions and 48 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 32
      subjects/ascii-art/ascii-art.audit.en.md
  2. 32
      subjects/ascii-art/ascii-reverse.audit.en.md

32
subjects/ascii-art/ascii-art.audit.en.md
unescape_control_characters View File

@ -204,31 +204,15 @@ __ _ _ _ _ _ _ _ __ _ __ __ _
#### Basic
###### *Has the code passed the formatting? (gofmt, goimports)
###### *Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc)
###### +Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc)
###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)?
###### *Does the code present commenting? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)
###### *Does the code present documentation?
###### *Does it present consistent indentation?
###### *Does the code avoid obvious comments? (no over information)
###### *Does the code avoid code grouping?
###### *Does the code have a consistent naming scheme (camelCase, under_scores)?
###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)?
###### *Does the code obey the principal "KISS" (keep it simple, stupid)?
###### *Does the code obey the principle "YAGNI" (You Are not Gonna Need It)?
###### *Does the code obey the principle "SOC" (Separation of Concerns)?
###### *Does the code avoid deep nesting (if in ifs, forest of ifs)?
###### *Does the code present a good file and folder organization?
###### *Does it present a good separation of Code and Data?
###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)
###### *Is the error handled, is it error free?
###### *Is there a test file for this code?
###### *Are the tests checking each possible case?
###### *Is the output of the program well structured? Does any letter seems to be out of line?
###### +Is there a test file for this code?
###### +Are the tests checking each possible case?
###### +Is the output of the program well structured? Does any letter seems to be out of line?
#### Social
###### *Did you learn anything from this project?
###### *Can it be open-sourced / be used for other sources?
###### *Would you recommend/nominate this program as an example for the rest of the school?
###### +Did you learn anything from this project?
###### +Can it be open-sourced / be used for other sources?
###### +Would you recommend/nominate this program as an example for the rest of the school?

32
subjects/ascii-art/ascii-reverse.audit.en.md
unescape_control_characters View File

@ -27,31 +27,15 @@
#### Basic
###### *Has the code passed the formatting? (gofmt, goimports)
###### *Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc)
###### +Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc)
###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)?
###### *Does the code present commenting (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)?
###### *Does the code present documentation?
###### *Does it present consistent indentation?
###### *Does the code avoid obvious comments? (no over information)
###### *Does the code avoid code grouping?
###### *Does the code have a consistent naming scheme (camelCase, under_scores)?
###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)?
###### *Does the code obey the principal "KISS" (keep it simple, stupid)?
###### *Does the code obey the principle "YAGNI" (You Are not Gonna Need It)?
###### *Does the code obey the principle "SOC" (Separation of Concerns)?
###### *Does the code avoid deep nesting (if in ifs, forest of ifs)?
###### *Does the code present a good file and folder organization?
###### *Does it present a good separation of Code and Data?
###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)
###### *Is the error handled, is it error free?
###### *Is there a test file for this code?
###### *Are the tests checking each case possible?
###### *Is the output of the program well structured? Does any letter seems to be out of line?
###### +Is there a test file for this code?
###### +Are the tests checking each possible case?
###### +Is the output of the program well structured? Does any letter seems to be out of line?
#### Social
###### *Did you learn anything from this project?
###### *Can it be open-sourced / be used for other sources?
###### *Would you recommend/nominate this program as an example for the rest of the school?
###### +Did you learn anything from this project?
###### +Can it be open-sourced / be used for other sources?
###### +Would you recommend/nominate this program as an example for the rest of the school?

Write Preview
Loading…
Cancel
Save