From 986b43d141b5305d88c04fed394c676a79fc5152 Mon Sep 17 00:00:00 2001 From: OGordoo Date: Mon, 23 Dec 2019 16:18:10 +0000 Subject: [PATCH 1/9] creation questions tetrisoptimizer --- subjects/tetrisoptimizer.audit.en.md | 65 ++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 subjects/tetrisoptimizer.audit.en.md diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md new file mode 100644 index 00000000..10b6aa62 --- /dev/null +++ b/subjects/tetrisoptimizer.audit.en.md @@ -0,0 +1,65 @@ +#### Functional Project Questions + +##### Try bad example 00 (github.com/public/subject/badexample00.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 01 (github.com/public/subject/badexample01.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 02 (github.com/public/subject/badexample02.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 03 (github.com/public/subject/badexample03.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 04 (github.com/public/subject/badexample04.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad format (github.com/public/subject/badformat.md). +`ERROR` +###### Does the program prints the value above? +##### Try good example 00 (github.com/public/subject/goodexample00.md). +###### Does the result contain 0 empty spaces (0 '.') ? +##### Try good example 01 (github.com/public/subject/goodexample01.md). +###### Does the result contain 9 empty spaces (9 '.') ? +##### Try good example 02 (github.com/public/subject/goodexample02.md). +###### Does the result contain 4 empty spaces (4 '.') ? +##### Try good example 03 (github.com/public/subject/goodexample03.md). +###### Does the result contain 5 empty spaces (5 '.') ? +##### Try hard example (github.com/public/subject/hardexam.md). +###### Does the result contain 1 empty spaces (1 '.') ? +##### Are all of the Tetrominos contained in the test file, present in the output? +##### Different characters correspond to different Tetrominos? +##### Does one Tetromino has only one character? + +#### Basic + +###### *Has the code passed the formatting? (gofmt, goimports) + +###### *Does the program avoid the use of packages? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) +###### *Does the code present commenting ? +###### *Does the code present documentation? +###### *Does it present consistent indentation? +###### *Does the code avoid obvious comments (no over information)? +###### *Does the code have a consistent naming scheme (camelCase, under_scores)? +###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? +###### *Does the code obey the principal "KISS" (Keep It Simple, Stupid)? +###### *Does the code obey the principle YAGNI (You Aren’t Gonna Need It)? +###### *Does the code obey the principle SOC (Separation of Concerns)? +###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? +###### *Does the code present a good file and folder organization? +###### *Does it present a good separation of Code and Data? +###### *Does the go code follow the go recommendations? ((https://golang.org/doc/effective_go.html), (https://golang.org/cmd/gofmt/), (https://godoc.org/golang.org/x/tools/cmd/goimports), (https://goinbigdata.com/goimports-vs-gofmt/)) + +###### *Is there a test file for this code? +###### *Are the tests checking each case? + +###### *Is the error handled, is it error free? + +###### *Does the project runs quickly and effectively (Favoring of recursivity, no unnecessary data requests, etc.)? + +#### Social + +###### *Can the project be used for a common good? +###### *Did you learn anything from this project? +###### *Would you recommend/nominate this program as an example for the rest of the school? \ No newline at end of file From 234b715d4d868d76908d2475f26920ed474b7503 Mon Sep 17 00:00:00 2001 From: OGordoo Date: Mon, 23 Dec 2019 16:55:30 +0000 Subject: [PATCH 2/9] fixes questions --- subjects/tetrisoptimizer.audit.en.md | 33 +++++++++++++--------------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md index 10b6aa62..a2435c00 100644 --- a/subjects/tetrisoptimizer.audit.en.md +++ b/subjects/tetrisoptimizer.audit.en.md @@ -1,6 +1,6 @@ #### Functional Project Questions -##### Try bad example 00 (github.com/public/subject/badexample00.md). +##### Try bad example 00 (github.com/public/subject/badexample00.md). `ERROR` ###### Does the program prints the value above? ##### Try bad example 01 (github.com/public/subject/badexample01.md). @@ -19,25 +19,26 @@ `ERROR` ###### Does the program prints the value above? ##### Try good example 00 (github.com/public/subject/goodexample00.md). -###### Does the result contain 0 empty spaces (0 '.') ? +###### Does the result contain 0 empty spaces (0 '.')? ##### Try good example 01 (github.com/public/subject/goodexample01.md). -###### Does the result contain 9 empty spaces (9 '.') ? +###### Does the result contain 9 empty spaces (9 '.')? ##### Try good example 02 (github.com/public/subject/goodexample02.md). -###### Does the result contain 4 empty spaces (4 '.') ? +###### Does the result contain 4 empty spaces (4 '.')? ##### Try good example 03 (github.com/public/subject/goodexample03.md). -###### Does the result contain 5 empty spaces (5 '.') ? +###### Does the result contain 5 empty spaces (5 '.')? ##### Try hard example (github.com/public/subject/hardexam.md). -###### Does the result contain 1 empty spaces (1 '.') ? -##### Are all of the Tetrominos contained in the test file, present in the output? -##### Different characters correspond to different Tetrominos? -##### Does one Tetromino has only one character? +###### Does the result contain 1 empty spaces (1 '.')? +###### Are all of the Tetrominos contained in the test file, present in the output? +###### Different characters correspond to different Tetrominos? +###### Does one Tetromino has only one character? #### Basic ###### *Has the code passed the formatting? (gofmt, goimports) +###### *Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? -###### *Does the program avoid the use of packages? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) -###### *Does the code present commenting ? +###### *Does the program avoid the use of packages? +###### *Does the code present commenting? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) ###### *Does the code present documentation? ###### *Does it present consistent indentation? ###### *Does the code avoid obvious comments (no over information)? @@ -49,17 +50,13 @@ ###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? ###### *Does the code present a good file and folder organization? ###### *Does it present a good separation of Code and Data? -###### *Does the go code follow the go recommendations? ((https://golang.org/doc/effective_go.html), (https://golang.org/cmd/gofmt/), (https://godoc.org/golang.org/x/tools/cmd/goimports), (https://goinbigdata.com/goimports-vs-gofmt/)) +###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) ###### *Is there a test file for this code? -###### *Are the tests checking each case? - +###### *Are the tests checking each possible case? ###### *Is the error handled, is it error free? -###### *Does the project runs quickly and effectively (Favoring of recursivity, no unnecessary data requests, etc.)? - #### Social -###### *Can the project be used for a common good? ###### *Did you learn anything from this project? -###### *Would you recommend/nominate this program as an example for the rest of the school? \ No newline at end of file +###### *Would you recommend/nominate this program as an example for the rest of the school? From ae96dd09ca58a4ec5839fc0e0bce248cdca176d2 Mon Sep 17 00:00:00 2001 From: OGordoo <39002518+OGordoo@users.noreply.github.com> Date: Mon, 23 Dec 2019 17:11:05 +0000 Subject: [PATCH 3/9] new fix --- subjects/tetrisoptimizer.audit.en.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md index a2435c00..fdd956c3 100644 --- a/subjects/tetrisoptimizer.audit.en.md +++ b/subjects/tetrisoptimizer.audit.en.md @@ -45,8 +45,8 @@ ###### *Does the code have a consistent naming scheme (camelCase, under_scores)? ###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? ###### *Does the code obey the principal "KISS" (Keep It Simple, Stupid)? -###### *Does the code obey the principle YAGNI (You Aren’t Gonna Need It)? -###### *Does the code obey the principle SOC (Separation of Concerns)? +###### *Does the code obey the principle "YAGNI" (You Aren’t Gonna Need It)? +###### *Does the code obey the principle "SOC" (Separation of Concerns)? ###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? ###### *Does the code present a good file and folder organization? ###### *Does it present a good separation of Code and Data? From 3bb4a7f6d64b92098883a78c42401a14e68536c4 Mon Sep 17 00:00:00 2001 From: OGordoo Date: Mon, 23 Dec 2019 16:18:10 +0000 Subject: [PATCH 4/9] creation questions tetrisoptimizer --- subjects/tetrisoptimizer.audit.en.md | 65 ++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 subjects/tetrisoptimizer.audit.en.md diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md new file mode 100644 index 00000000..10b6aa62 --- /dev/null +++ b/subjects/tetrisoptimizer.audit.en.md @@ -0,0 +1,65 @@ +#### Functional Project Questions + +##### Try bad example 00 (github.com/public/subject/badexample00.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 01 (github.com/public/subject/badexample01.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 02 (github.com/public/subject/badexample02.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 03 (github.com/public/subject/badexample03.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 04 (github.com/public/subject/badexample04.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad format (github.com/public/subject/badformat.md). +`ERROR` +###### Does the program prints the value above? +##### Try good example 00 (github.com/public/subject/goodexample00.md). +###### Does the result contain 0 empty spaces (0 '.') ? +##### Try good example 01 (github.com/public/subject/goodexample01.md). +###### Does the result contain 9 empty spaces (9 '.') ? +##### Try good example 02 (github.com/public/subject/goodexample02.md). +###### Does the result contain 4 empty spaces (4 '.') ? +##### Try good example 03 (github.com/public/subject/goodexample03.md). +###### Does the result contain 5 empty spaces (5 '.') ? +##### Try hard example (github.com/public/subject/hardexam.md). +###### Does the result contain 1 empty spaces (1 '.') ? +##### Are all of the Tetrominos contained in the test file, present in the output? +##### Different characters correspond to different Tetrominos? +##### Does one Tetromino has only one character? + +#### Basic + +###### *Has the code passed the formatting? (gofmt, goimports) + +###### *Does the program avoid the use of packages? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) +###### *Does the code present commenting ? +###### *Does the code present documentation? +###### *Does it present consistent indentation? +###### *Does the code avoid obvious comments (no over information)? +###### *Does the code have a consistent naming scheme (camelCase, under_scores)? +###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? +###### *Does the code obey the principal "KISS" (Keep It Simple, Stupid)? +###### *Does the code obey the principle YAGNI (You Aren’t Gonna Need It)? +###### *Does the code obey the principle SOC (Separation of Concerns)? +###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? +###### *Does the code present a good file and folder organization? +###### *Does it present a good separation of Code and Data? +###### *Does the go code follow the go recommendations? ((https://golang.org/doc/effective_go.html), (https://golang.org/cmd/gofmt/), (https://godoc.org/golang.org/x/tools/cmd/goimports), (https://goinbigdata.com/goimports-vs-gofmt/)) + +###### *Is there a test file for this code? +###### *Are the tests checking each case? + +###### *Is the error handled, is it error free? + +###### *Does the project runs quickly and effectively (Favoring of recursivity, no unnecessary data requests, etc.)? + +#### Social + +###### *Can the project be used for a common good? +###### *Did you learn anything from this project? +###### *Would you recommend/nominate this program as an example for the rest of the school? \ No newline at end of file From 36ef1c267b72cc58268fd38628abda9282b5471a Mon Sep 17 00:00:00 2001 From: OGordoo Date: Mon, 23 Dec 2019 16:55:30 +0000 Subject: [PATCH 5/9] fixes questions --- subjects/tetrisoptimizer.audit.en.md | 33 +++++++++++++--------------- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md index 10b6aa62..a2435c00 100644 --- a/subjects/tetrisoptimizer.audit.en.md +++ b/subjects/tetrisoptimizer.audit.en.md @@ -1,6 +1,6 @@ #### Functional Project Questions -##### Try bad example 00 (github.com/public/subject/badexample00.md). +##### Try bad example 00 (github.com/public/subject/badexample00.md). `ERROR` ###### Does the program prints the value above? ##### Try bad example 01 (github.com/public/subject/badexample01.md). @@ -19,25 +19,26 @@ `ERROR` ###### Does the program prints the value above? ##### Try good example 00 (github.com/public/subject/goodexample00.md). -###### Does the result contain 0 empty spaces (0 '.') ? +###### Does the result contain 0 empty spaces (0 '.')? ##### Try good example 01 (github.com/public/subject/goodexample01.md). -###### Does the result contain 9 empty spaces (9 '.') ? +###### Does the result contain 9 empty spaces (9 '.')? ##### Try good example 02 (github.com/public/subject/goodexample02.md). -###### Does the result contain 4 empty spaces (4 '.') ? +###### Does the result contain 4 empty spaces (4 '.')? ##### Try good example 03 (github.com/public/subject/goodexample03.md). -###### Does the result contain 5 empty spaces (5 '.') ? +###### Does the result contain 5 empty spaces (5 '.')? ##### Try hard example (github.com/public/subject/hardexam.md). -###### Does the result contain 1 empty spaces (1 '.') ? -##### Are all of the Tetrominos contained in the test file, present in the output? -##### Different characters correspond to different Tetrominos? -##### Does one Tetromino has only one character? +###### Does the result contain 1 empty spaces (1 '.')? +###### Are all of the Tetrominos contained in the test file, present in the output? +###### Different characters correspond to different Tetrominos? +###### Does one Tetromino has only one character? #### Basic ###### *Has the code passed the formatting? (gofmt, goimports) +###### *Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? -###### *Does the program avoid the use of packages? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) -###### *Does the code present commenting ? +###### *Does the program avoid the use of packages? +###### *Does the code present commenting? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) ###### *Does the code present documentation? ###### *Does it present consistent indentation? ###### *Does the code avoid obvious comments (no over information)? @@ -49,17 +50,13 @@ ###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? ###### *Does the code present a good file and folder organization? ###### *Does it present a good separation of Code and Data? -###### *Does the go code follow the go recommendations? ((https://golang.org/doc/effective_go.html), (https://golang.org/cmd/gofmt/), (https://godoc.org/golang.org/x/tools/cmd/goimports), (https://goinbigdata.com/goimports-vs-gofmt/)) +###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) ###### *Is there a test file for this code? -###### *Are the tests checking each case? - +###### *Are the tests checking each possible case? ###### *Is the error handled, is it error free? -###### *Does the project runs quickly and effectively (Favoring of recursivity, no unnecessary data requests, etc.)? - #### Social -###### *Can the project be used for a common good? ###### *Did you learn anything from this project? -###### *Would you recommend/nominate this program as an example for the rest of the school? \ No newline at end of file +###### *Would you recommend/nominate this program as an example for the rest of the school? From a7d5ae8c23dc35cb7113f7a0c73923d7b1316d5a Mon Sep 17 00:00:00 2001 From: OGordoo <39002518+OGordoo@users.noreply.github.com> Date: Mon, 23 Dec 2019 17:11:05 +0000 Subject: [PATCH 6/9] new fix --- subjects/tetrisoptimizer.audit.en.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md index a2435c00..fdd956c3 100644 --- a/subjects/tetrisoptimizer.audit.en.md +++ b/subjects/tetrisoptimizer.audit.en.md @@ -45,8 +45,8 @@ ###### *Does the code have a consistent naming scheme (camelCase, under_scores)? ###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? ###### *Does the code obey the principal "KISS" (Keep It Simple, Stupid)? -###### *Does the code obey the principle YAGNI (You Aren’t Gonna Need It)? -###### *Does the code obey the principle SOC (Separation of Concerns)? +###### *Does the code obey the principle "YAGNI" (You Aren’t Gonna Need It)? +###### *Does the code obey the principle "SOC" (Separation of Concerns)? ###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? ###### *Does the code present a good file and folder organization? ###### *Does it present a good separation of Code and Data? From 081908c3635533dfedb547a36f54367df68a1b95 Mon Sep 17 00:00:00 2001 From: lee Date: Tue, 24 Dec 2019 16:37:36 +0000 Subject: [PATCH 7/9] tetrisoptimizer fixes --- subjects/good-practices.en.md | 1 + .../{ => tetrisoptimizer}/badexample00.md | 0 .../{ => tetrisoptimizer}/badexample01.md | 0 .../{ => tetrisoptimizer}/badexample02.md | 0 .../{ => tetrisoptimizer}/badexample03.md | 0 .../{ => tetrisoptimizer}/badexample04.md | 0 subjects/{ => tetrisoptimizer}/badformat.md | 0 .../{ => tetrisoptimizer}/goodexample00.md | 0 .../{ => tetrisoptimizer}/goodexample01.md | 0 .../{ => tetrisoptimizer}/goodexample02.md | 0 .../{ => tetrisoptimizer}/goodexample03.md | 0 subjects/{ => tetrisoptimizer}/hardexam.md | 0 .../tetrisoptimizer.audit.en.md | 45 +++++++++++++++++++ .../tetrisoptimizer.en.md | 0 14 files changed, 46 insertions(+) rename subjects/{ => tetrisoptimizer}/badexample00.md (100%) rename subjects/{ => tetrisoptimizer}/badexample01.md (100%) rename subjects/{ => tetrisoptimizer}/badexample02.md (100%) rename subjects/{ => tetrisoptimizer}/badexample03.md (100%) rename subjects/{ => tetrisoptimizer}/badexample04.md (100%) rename subjects/{ => tetrisoptimizer}/badformat.md (100%) rename subjects/{ => tetrisoptimizer}/goodexample00.md (100%) rename subjects/{ => tetrisoptimizer}/goodexample01.md (100%) rename subjects/{ => tetrisoptimizer}/goodexample02.md (100%) rename subjects/{ => tetrisoptimizer}/goodexample03.md (100%) rename subjects/{ => tetrisoptimizer}/hardexam.md (100%) create mode 100644 subjects/tetrisoptimizer/tetrisoptimizer.audit.en.md rename subjects/{ => tetrisoptimizer}/tetrisoptimizer.en.md (100%) diff --git a/subjects/good-practices.en.md b/subjects/good-practices.en.md index 09ad819a..c7161eec 100644 --- a/subjects/good-practices.en.md +++ b/subjects/good-practices.en.md @@ -14,6 +14,7 @@ - [**YAGNI**](https://thefullstack.xyz/dry-yagni-kiss-tdd-soc-bdfu) (You Aren’t Gonna Need It) - [**SOC**](https://thefullstack.xyz/dry-yagni-kiss-tdd-soc-bdfu) (Separation of Concerns) - Avoid Deep Nesting +- Handling errors - Limit Line Length - File and Folder Organization - Consistent Temporary Names diff --git a/subjects/badexample00.md b/subjects/tetrisoptimizer/badexample00.md similarity index 100% rename from subjects/badexample00.md rename to subjects/tetrisoptimizer/badexample00.md diff --git a/subjects/badexample01.md b/subjects/tetrisoptimizer/badexample01.md similarity index 100% rename from subjects/badexample01.md rename to subjects/tetrisoptimizer/badexample01.md diff --git a/subjects/badexample02.md b/subjects/tetrisoptimizer/badexample02.md similarity index 100% rename from subjects/badexample02.md rename to subjects/tetrisoptimizer/badexample02.md diff --git a/subjects/badexample03.md b/subjects/tetrisoptimizer/badexample03.md similarity index 100% rename from subjects/badexample03.md rename to subjects/tetrisoptimizer/badexample03.md diff --git a/subjects/badexample04.md b/subjects/tetrisoptimizer/badexample04.md similarity index 100% rename from subjects/badexample04.md rename to subjects/tetrisoptimizer/badexample04.md diff --git a/subjects/badformat.md b/subjects/tetrisoptimizer/badformat.md similarity index 100% rename from subjects/badformat.md rename to subjects/tetrisoptimizer/badformat.md diff --git a/subjects/goodexample00.md b/subjects/tetrisoptimizer/goodexample00.md similarity index 100% rename from subjects/goodexample00.md rename to subjects/tetrisoptimizer/goodexample00.md diff --git a/subjects/goodexample01.md b/subjects/tetrisoptimizer/goodexample01.md similarity index 100% rename from subjects/goodexample01.md rename to subjects/tetrisoptimizer/goodexample01.md diff --git a/subjects/goodexample02.md b/subjects/tetrisoptimizer/goodexample02.md similarity index 100% rename from subjects/goodexample02.md rename to subjects/tetrisoptimizer/goodexample02.md diff --git a/subjects/goodexample03.md b/subjects/tetrisoptimizer/goodexample03.md similarity index 100% rename from subjects/goodexample03.md rename to subjects/tetrisoptimizer/goodexample03.md diff --git a/subjects/hardexam.md b/subjects/tetrisoptimizer/hardexam.md similarity index 100% rename from subjects/hardexam.md rename to subjects/tetrisoptimizer/hardexam.md diff --git a/subjects/tetrisoptimizer/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer/tetrisoptimizer.audit.en.md new file mode 100644 index 00000000..8d29e01e --- /dev/null +++ b/subjects/tetrisoptimizer/tetrisoptimizer.audit.en.md @@ -0,0 +1,45 @@ +#### Functional Project Questions + +##### Try bad example 00 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/badexample00.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 01 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/badexample01.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 02 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/badexample02.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 03 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/badexample03.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad example 04 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/badexample04.md). +`ERROR` +###### Does the program prints the value above? +##### Try bad format (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/badformat.md). +`ERROR` +###### Does the program prints the value above? +##### Try good example 00 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/goodexample00.md). +###### Does the result contain 0 empty spaces (0 '.')? +##### Try good example 01 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/goodexample01.md). +###### Does the result contain 9 empty spaces (9 '.')? +##### Try good example 02 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/goodexample02.md). +###### Does the result contain 4 empty spaces (4 '.')? +##### Try good example 03 (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/goodexample03.md). +###### Does the result contain 5 empty spaces (5 '.')? +##### Try hard example (https://github.com/01-edu/public/blob/master/subjects/tetrisoptimizer/hardexam.md). +###### Does the result contain 1 empty spaces (1 '.')? +###### Are all of the Tetrominos contained in the test file, present in the output? +###### Different characters correspond to different Tetrominos? +###### Does one Tetromino has only one character? + +#### Basic + +###### +Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? +###### +Is there a test file for this code? +###### +Are the tests checking each possible case? +###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? + +#### Social + +###### +Did you learn anything from this project? +###### +Would you recommend/nominate this program as an example for the rest of the school? diff --git a/subjects/tetrisoptimizer.en.md b/subjects/tetrisoptimizer/tetrisoptimizer.en.md similarity index 100% rename from subjects/tetrisoptimizer.en.md rename to subjects/tetrisoptimizer/tetrisoptimizer.en.md From bd0bd2248e1c76a9c19b1dc4df1f8a9310b4f003 Mon Sep 17 00:00:00 2001 From: lee Date: Tue, 24 Dec 2019 16:46:00 +0000 Subject: [PATCH 8/9] removing files --- subjects/tetrisoptimizer.audit.en.md | 62 ---------------------------- 1 file changed, 62 deletions(-) delete mode 100644 subjects/tetrisoptimizer.audit.en.md diff --git a/subjects/tetrisoptimizer.audit.en.md b/subjects/tetrisoptimizer.audit.en.md deleted file mode 100644 index fdd956c3..00000000 --- a/subjects/tetrisoptimizer.audit.en.md +++ /dev/null @@ -1,62 +0,0 @@ -#### Functional Project Questions - -##### Try bad example 00 (github.com/public/subject/badexample00.md). -`ERROR` -###### Does the program prints the value above? -##### Try bad example 01 (github.com/public/subject/badexample01.md). -`ERROR` -###### Does the program prints the value above? -##### Try bad example 02 (github.com/public/subject/badexample02.md). -`ERROR` -###### Does the program prints the value above? -##### Try bad example 03 (github.com/public/subject/badexample03.md). -`ERROR` -###### Does the program prints the value above? -##### Try bad example 04 (github.com/public/subject/badexample04.md). -`ERROR` -###### Does the program prints the value above? -##### Try bad format (github.com/public/subject/badformat.md). -`ERROR` -###### Does the program prints the value above? -##### Try good example 00 (github.com/public/subject/goodexample00.md). -###### Does the result contain 0 empty spaces (0 '.')? -##### Try good example 01 (github.com/public/subject/goodexample01.md). -###### Does the result contain 9 empty spaces (9 '.')? -##### Try good example 02 (github.com/public/subject/goodexample02.md). -###### Does the result contain 4 empty spaces (4 '.')? -##### Try good example 03 (github.com/public/subject/goodexample03.md). -###### Does the result contain 5 empty spaces (5 '.')? -##### Try hard example (github.com/public/subject/hardexam.md). -###### Does the result contain 1 empty spaces (1 '.')? -###### Are all of the Tetrominos contained in the test file, present in the output? -###### Different characters correspond to different Tetrominos? -###### Does one Tetromino has only one character? - -#### Basic - -###### *Has the code passed the formatting? (gofmt, goimports) -###### *Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? - -###### *Does the program avoid the use of packages? -###### *Does the code present commenting? (github.com/01-edu/public/blob/master/subjects/good-practices.en.md) -###### *Does the code present documentation? -###### *Does it present consistent indentation? -###### *Does the code avoid obvious comments (no over information)? -###### *Does the code have a consistent naming scheme (camelCase, under_scores)? -###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? -###### *Does the code obey the principal "KISS" (Keep It Simple, Stupid)? -###### *Does the code obey the principle "YAGNI" (You Aren’t Gonna Need It)? -###### *Does the code obey the principle "SOC" (Separation of Concerns)? -###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? -###### *Does the code present a good file and folder organization? -###### *Does it present a good separation of Code and Data? -###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) - -###### *Is there a test file for this code? -###### *Are the tests checking each possible case? -###### *Is the error handled, is it error free? - -#### Social - -###### *Did you learn anything from this project? -###### *Would you recommend/nominate this program as an example for the rest of the school? From cb67ca369d1e71bd1d974f1a737fa965d1c0bb4a Mon Sep 17 00:00:00 2001 From: lee Date: Tue, 24 Dec 2019 16:52:19 +0000 Subject: [PATCH 9/9] removing '*' and fixing linkto good practices --- subjects/ascii-art/ascii-art.audit.en.md | 32 +++++--------------- subjects/ascii-art/ascii-reverse.audit.en.md | 32 +++++--------------- 2 files changed, 16 insertions(+), 48 deletions(-) diff --git a/subjects/ascii-art/ascii-art.audit.en.md b/subjects/ascii-art/ascii-art.audit.en.md index a01a1d5a..65d90ef2 100644 --- a/subjects/ascii-art/ascii-art.audit.en.md +++ b/subjects/ascii-art/ascii-art.audit.en.md @@ -204,31 +204,15 @@ __ _ _ _ _ _ _ _ __ _ __ __ _ #### Basic -###### *Has the code passed the formatting? (gofmt, goimports) -###### *Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) +###### +Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) +###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? -###### *Does the code present commenting? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) -###### *Does the code present documentation? -###### *Does it present consistent indentation? -###### *Does the code avoid obvious comments? (no over information) -###### *Does the code avoid code grouping? -###### *Does the code have a consistent naming scheme (camelCase, under_scores)? -###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? -###### *Does the code obey the principal "KISS" (keep it simple, stupid)? -###### *Does the code obey the principle "YAGNI" (You Are not Gonna Need It)? -###### *Does the code obey the principle "SOC" (Separation of Concerns)? -###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? -###### *Does the code present a good file and folder organization? -###### *Does it present a good separation of Code and Data? -###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) - -###### *Is the error handled, is it error free? -###### *Is there a test file for this code? -###### *Are the tests checking each possible case? -###### *Is the output of the program well structured? Does any letter seems to be out of line? +###### +Is there a test file for this code? +###### +Are the tests checking each possible case? +###### +Is the output of the program well structured? Does any letter seems to be out of line? #### Social -###### *Did you learn anything from this project? -###### *Can it be open-sourced / be used for other sources? -###### *Would you recommend/nominate this program as an example for the rest of the school? +###### +Did you learn anything from this project? +###### +Can it be open-sourced / be used for other sources? +###### +Would you recommend/nominate this program as an example for the rest of the school? diff --git a/subjects/ascii-art/ascii-reverse.audit.en.md b/subjects/ascii-art/ascii-reverse.audit.en.md index 57fd3999..250bf1fa 100644 --- a/subjects/ascii-art/ascii-reverse.audit.en.md +++ b/subjects/ascii-art/ascii-reverse.audit.en.md @@ -27,31 +27,15 @@ #### Basic -###### *Has the code passed the formatting? (gofmt, goimports) -###### *Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) +###### +Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) +###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? -###### *Does the code present commenting (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? -###### *Does the code present documentation? -###### *Does it present consistent indentation? -###### *Does the code avoid obvious comments? (no over information) -###### *Does the code avoid code grouping? -###### *Does the code have a consistent naming scheme (camelCase, under_scores)? -###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? -###### *Does the code obey the principal "KISS" (keep it simple, stupid)? -###### *Does the code obey the principle "YAGNI" (You Are not Gonna Need It)? -###### *Does the code obey the principle "SOC" (Separation of Concerns)? -###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? -###### *Does the code present a good file and folder organization? -###### *Does it present a good separation of Code and Data? -###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) - -###### *Is the error handled, is it error free? -###### *Is there a test file for this code? -###### *Are the tests checking each case possible? -###### *Is the output of the program well structured? Does any letter seems to be out of line? +###### +Is there a test file for this code? +###### +Are the tests checking each possible case? +###### +Is the output of the program well structured? Does any letter seems to be out of line? #### Social -###### *Did you learn anything from this project? -###### *Can it be open-sourced / be used for other sources? -###### *Would you recommend/nominate this program as an example for the rest of the school? +###### +Did you learn anything from this project? +###### +Can it be open-sourced / be used for other sources? +###### +Would you recommend/nominate this program as an example for the rest of the school?