From 3cfdccd7cff9d9f527a5453037377db6b995478c Mon Sep 17 00:00:00 2001 From: lee Date: Fri, 10 Jan 2020 17:43:38 +0000 Subject: [PATCH] reviewing subject and questions --- .../groupie-trackers-search-bar.audit.en.md | 16 +++++----------- .../groupie-trackers-search-bar.en.md | 10 +++++----- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md b/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md index eefc4295..1c5ecbc4 100644 --- a/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md +++ b/subjects/groupie-trackers/groupie-trackers-search-bar.audit.en.md @@ -1,22 +1,22 @@ #### Functional -##### Try to start typing in the search bar `"Billie Joe"`. +##### Start typing in the search bar `"Billie Joe"`. ###### Does it present as suggestions the member "Billie Joe Armstrong"? -##### Try to start typing in the search bar `"Japan"`. -###### Does it present as suggestions "saitama-japan", "osaka-japan" and "nagoya-japan"? +##### Start typing in the search bar `"Japan"`. +###### Does it present as suggestions the locations "saitama-japan", "osaka-japan" and "nagoya-japan"? ##### Try to search for the artist/band `"Scorpions"`. ###### Does it present as result "Scorpions"? ##### Try to search for the member `"Jimi Hendrix"`. -###### Does it present as result "The Jimi Hendrix Experience"? +###### Does it present as result the artist/band "The Jimi Hendrix Experience"? ##### Try to search for the member `"Phil Collins"`. ###### Does it present as result "Phil Collins" and "Genesis"? ##### Try to search for the location `"london-uk"`. -###### Does it present as result "Pink Floyd", "Led Zeppelin", "Aerosmith", "Alec Benjamin", "Nickelback", "Eagles", "Linkin Park" and "Coldplay"? +###### Does it present as result "Pink Floyd", "Led Zeppelin", "Aerosmith", "Alec Benjamin", "Nickelback", "Eagles", "Linkin Park" and "Coldplay"? ##### Try to search for the artist/band `"queen"`. ###### Does it handle the case sensitive and presents as result "Queen"? @@ -30,12 +30,6 @@ ##### Try to search for the creation date `"1965"`. ###### Does it present as result "Scorpions" and "Pink Floyd"? -#### General - -###### +Does the search bar have typing suggestions as you write? -###### +Is there a search icon and button? -###### +Is the search bar or button Animated? - #### Basic ###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? diff --git a/subjects/groupie-trackers/groupie-trackers-search-bar.en.md b/subjects/groupie-trackers/groupie-trackers-search-bar.en.md index 9e013111..f08f9d52 100644 --- a/subjects/groupie-trackers/groupie-trackers-search-bar.en.md +++ b/subjects/groupie-trackers/groupie-trackers-search-bar.en.md @@ -15,14 +15,14 @@ Groupie-trackers-search-bar consists of creating a functional program that searc - The program must handle case sensitive. - The search bar must have typing suggestions as you write. - The search bar must identify and display in each suggestion the individual type of the search cases. (ex: Freddie Mercury -> member) - - Example if you start writing `"phil"` it should appear as suggestions `Phil Collins -> member` and `Phil Collins -> artist/band`. This is just an example of a display. + - Example if you start writing `"phil"` it should appear as suggestions `Phil Collins - member` and `Phil Collins - artist/band`. This is just an example of a display. This project will help you learn about : -- Manipulation, display and storage of data. -- HTML. -- [Events](https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/Events) creation and display. -- JSON files and format. + - Manipulation, display and storage of data. + - HTML. + - [Events](https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/) creation and display. + - JSON files and format. ### Instructions