From cad068770327b7524895c95cb419ad862f4cba5b Mon Sep 17 00:00:00 2001 From: miguel Date: Tue, 14 Dec 2021 17:12:39 +0000 Subject: [PATCH 1/5] taking care of issue in public regarding testing in the project --- subjects/ascii-art-web/stylize/audit.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/subjects/ascii-art-web/stylize/audit.md b/subjects/ascii-art-web/stylize/audit.md index 481b7676..c4c3cb89 100644 --- a/subjects/ascii-art-web/stylize/audit.md +++ b/subjects/ascii-art-web/stylize/audit.md @@ -22,10 +22,6 @@ ###### +Is the output of the program well structured? Is the output aligned, without any letter out of line? -###### +Is there a test file for this code? - -###### +Are the tests checking each possible case? - ###### +Does the code obey the [good practices](../../good-practices/README.md)? #### Social From 5902686a7b15705d95e117657c3cf6da1d2d6264 Mon Sep 17 00:00:00 2001 From: miguel Date: Wed, 15 Dec 2021 11:25:23 +0000 Subject: [PATCH 2/5] removal of a confusing instruction acording to the students --- subjects/ascii-art-web/export-file/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/subjects/ascii-art-web/export-file/README.md b/subjects/ascii-art-web/export-file/README.md index 6d8f1268..f6028d28 100644 --- a/subjects/ascii-art-web/export-file/README.md +++ b/subjects/ascii-art-web/export-file/README.md @@ -30,7 +30,6 @@ As you already learned from the previous project you must create a new HTTP endp This project will help you learn about : - The basics of export formats : - - Portable Document Format (pdf) - Text File (txt) - [Here are some more examples](https://en.wikipedia.org/wiki/Document_file_format) - [HTTP headers](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers) From a1250452dce29204b3c019a7edb40816be14be85 Mon Sep 17 00:00:00 2001 From: miguel Date: Fri, 17 Dec 2021 12:39:35 +0000 Subject: [PATCH 3/5] explaining events in groupie trackers according to an issue --- subjects/groupie-tracker/README.md | 7 ++++--- subjects/groupie-tracker/audit/README.md | 14 ++++++++------ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/subjects/groupie-tracker/README.md b/subjects/groupie-tracker/README.md index 01d688b0..6ddebee2 100644 --- a/subjects/groupie-tracker/README.md +++ b/subjects/groupie-tracker/README.md @@ -14,10 +14,11 @@ Groupie Trackers consists on receiving a given API and manipulate the data conta - And the last one, `relation`, does the link between all the other parts, `artists`, `dates` and `locations`. -- Given all this you should build a user friendly website where you can display the bands info through several data visualizations (examples : blocks, cards, tables, list, pages, graphics, etc). It is up to you to decide which info you will present and how you will display it. +- Given all this you should build a user friendly website where you can display the bands info through several data visualizations (examples : blocks, cards, tables, list, pages, graphics, etc). It is up to you to decide how you will display it. -- This project also focuses on the creation of events and on their visualization. +- This project also focuses on the creation of events/actions and on their visualization. + - For now the event/action we want you to do is known as a client call to the server ([client-server])(https://en.wikipedia.org/wiki/Request%E2%80%93response). We can say it is a feature of your choice that needs to trigger an action. - An event consists in a system that responds to some kind of action triggered by the client, time, or any other factor. ### Instructions @@ -42,4 +43,4 @@ This project will help you learn about : - [JSON](https://www.json.org/json-en.html) files and format. - HTML. - Event creation and display. - - [Events](https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Building_blocks/Events). + - [Client-server](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps/Client-Server_overview). diff --git a/subjects/groupie-tracker/audit/README.md b/subjects/groupie-tracker/audit/README.md index 3f88c65c..2f10eed3 100644 --- a/subjects/groupie-tracker/audit/README.md +++ b/subjects/groupie-tracker/audit/README.md @@ -2,9 +2,13 @@ ###### Has the requirement for the allowed packages been respected? (Reminder for this project: only [standard packages](https://golang.org/pkg/)) -###### Is the data from the artists being used? +###### Is the data from the `artists` being used? -###### Is data from the relations being used? +###### Is the data from the `locations` being used? + +###### Is the data from the `dates` being used? + +###### Is data from the `relations` being used? ##### Try to see the "members" for the artist/band `"Queen"` @@ -58,9 +62,9 @@ ###### Does it present the right members as above? -##### Try to trigger an event using some kind of action (ex: Clicking the mouse over a certain element, pressing a key on the keyboard, resizing or closing the browser window, a form being submitted, an error occurring, etc). +##### Try to trigger an event/action using some kind of action (ex: Clicking the mouse over a certain element, pressing a key on the keyboard, resizing or closing the browser window, a form being submitted, an error occurring, etc). -###### Does the event responds as expected? +###### Does the event/action responds as expected? ###### Did the server behaved as expected?(did not crashed) @@ -70,8 +74,6 @@ ###### Are all the pages working? (Absence of 404 page?) -###### Does the project handle [HTTP status 400 - Bad Requests](https://kinsta.com/knowledgebase/400-bad-request/#causes)? - ###### Does the project handle [HTTP status 500 - Internal Server Errors](https://www.restapitutorial.com/httpstatuscodes.html)? ###### Is the communication between server and client well established? From 1b7d85638a6fa694c28941dfe9b113a31c62af8d Mon Sep 17 00:00:00 2001 From: miguel Date: Fri, 17 Dec 2021 13:18:29 +0000 Subject: [PATCH 4/5] adding an explanation --- subjects/groupie-tracker/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subjects/groupie-tracker/README.md b/subjects/groupie-tracker/README.md index 6ddebee2..95e7d8d0 100644 --- a/subjects/groupie-tracker/README.md +++ b/subjects/groupie-tracker/README.md @@ -18,7 +18,7 @@ Groupie Trackers consists on receiving a given API and manipulate the data conta - This project also focuses on the creation of events/actions and on their visualization. - - For now the event/action we want you to do is known as a client call to the server ([client-server])(https://en.wikipedia.org/wiki/Request%E2%80%93response). We can say it is a feature of your choice that needs to trigger an action. + - The event/action we want you to do is known as a client call to the server ([client-server])(https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps/Client-Server_overview). We can say it is a feature of your choice that needs to trigger an action. This action must communicate with the server in order to recieve information, ([request-response])(https://en.wikipedia.org/wiki/Request%E2%80%93response) - An event consists in a system that responds to some kind of action triggered by the client, time, or any other factor. ### Instructions From f72574a88ffbae5e3fd46176498cc0ec918a3954 Mon Sep 17 00:00:00 2001 From: miguel Date: Fri, 17 Dec 2021 13:30:59 +0000 Subject: [PATCH 5/5] adding an explanation --- subjects/groupie-tracker/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subjects/groupie-tracker/README.md b/subjects/groupie-tracker/README.md index 95e7d8d0..d0cc2010 100644 --- a/subjects/groupie-tracker/README.md +++ b/subjects/groupie-tracker/README.md @@ -18,7 +18,7 @@ Groupie Trackers consists on receiving a given API and manipulate the data conta - This project also focuses on the creation of events/actions and on their visualization. - - The event/action we want you to do is known as a client call to the server ([client-server])(https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps/Client-Server_overview). We can say it is a feature of your choice that needs to trigger an action. This action must communicate with the server in order to recieve information, ([request-response])(https://en.wikipedia.org/wiki/Request%E2%80%93response) + - The event/action we want you to do is known as a client call to the server (client-server). We can say it is a feature of your choice that needs to trigger an action. This action must communicate with the server in order to recieve information, ([request-response])(https://en.wikipedia.org/wiki/Request%E2%80%93response) - An event consists in a system that responds to some kind of action triggered by the client, time, or any other factor. ### Instructions @@ -43,4 +43,4 @@ This project will help you learn about : - [JSON](https://www.json.org/json-en.html) files and format. - HTML. - Event creation and display. - - [Client-server](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps/Client-Server_overview). +- [Client-server](https://developer.mozilla.org/en-US/docs/Learn/Server-side/First_steps/Client-Server_overview).