|
|
@ -19,36 +19,18 @@ |
|
|
|
|
|
|
|
|
|
|
|
#### General Requirements |
|
|
|
#### General Requirements |
|
|
|
|
|
|
|
|
|
|
|
##### *Is it easy/intuitive to specify letter(s) to be coloured? |
|
|
|
##### +Is it easy/intuitive to specify letter(s) to be coloured? |
|
|
|
##### *Can you use more than one color in the same string? |
|
|
|
##### +Can you use more than one color in the same string? |
|
|
|
|
|
|
|
|
|
|
|
#### Basic |
|
|
|
#### Basic |
|
|
|
|
|
|
|
|
|
|
|
###### *Has the code passed the formatting? (gofmt, goimports) |
|
|
|
###### +Does the project runs quickly and effectively (Favoring of recursive, no unnecessary data requests, etc.)? |
|
|
|
###### *Does the project runs quickly and effectively? (Favoring recursive, no unnecessary data requests, etc) |
|
|
|
###### +Is the output of the program well structured? Does any letter seems to be out of line? |
|
|
|
|
|
|
|
###### +Is there a test file for this code? |
|
|
|
###### *Does the code present commenting? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) |
|
|
|
###### +Are the tests checking each possible case? |
|
|
|
###### *Does the code present documentation? |
|
|
|
###### +Does the code obey the [good practices](https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md)? |
|
|
|
###### *Does it present consistent indentation? |
|
|
|
|
|
|
|
###### *Does the code avoid obvious comments (no over information)? |
|
|
|
|
|
|
|
###### *Does the code avoid code grouping? |
|
|
|
|
|
|
|
###### *Does the code have a consistent naming scheme (camelCase, under_scores)? |
|
|
|
|
|
|
|
###### *Does the code obey the principles "DRY" (Don't Repeat Yourself) or "DIE" (Duplication is Evil)? |
|
|
|
|
|
|
|
###### *Does the code obey the principal "KISS" (keep it simple, stupid)? |
|
|
|
|
|
|
|
###### *Does the code obey the principle "YAGNI" (You Are not Gonna Need It)? |
|
|
|
|
|
|
|
###### *Does the code obey the principle "SOC" (Separation of Concerns)? |
|
|
|
|
|
|
|
###### *Does the code avoid deep nesting (if in ifs, forest of ifs)? |
|
|
|
|
|
|
|
###### *Does the code present a good file and folder organization? |
|
|
|
|
|
|
|
###### *Does it present a good separation of Code and Data? |
|
|
|
|
|
|
|
###### *Does the go code follow the go recommendation? (https://github.com/01-edu/public/blob/master/subjects/good-practices.en.md) |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
###### *Is the error handled, is it error free? |
|
|
|
|
|
|
|
###### *Is there a test file for this code? |
|
|
|
|
|
|
|
###### *Are the tests checking each case possible? |
|
|
|
|
|
|
|
###### *Is the output of the program well structured? Does any letter seems to be out of line? |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
#### Social |
|
|
|
#### Social |
|
|
|
|
|
|
|
|
|
|
|
###### *Did you learn anything from this project? |
|
|
|
###### +Did you learn anything from this project? |
|
|
|
###### *Can it be open-sourced / be used for other sources? |
|
|
|
###### +Would you recommend/nominate this program as an example for the rest of the school? |
|
|
|
###### *Would you recommend/nominate this program as an example for the rest of the school? |
|
|
|
|
|
|
|